Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 23453033: Have DOMPatchSupport and DocumentFragment deal with Document references (Closed)

Created:
7 years, 3 months ago by do-not-use
Modified:
7 years, 3 months ago
CC:
blink-reviews, caseq+blink_chromium.org, nessy, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, jeez, vcarbune.chromium, groby+blinkspell_chromium.org
Visibility:
Public.

Description

Have DOMPatchSupport and DocumentFragment deal with Document references Have DOMPatchSupport and DocumentFragment deal with Document references instead of using pointers with assertions to make sure the pointers are non-null. The DocumentFragment constructor still takes a Document pointer in argument because of ShadowRoot which passes 0 as Document until it is set later on by TreeScope. I need to investigate more to determine if the DocumentFragment constructor can take a reference in. BUG=281400 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157237

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentFragment.h View 1 chunk +1 line, -6 lines 0 comments Download
M Source/core/dom/DocumentFragment.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TemplateContentDocumentFragment.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditorCommand.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/editing/markup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/markup.cpp View 4 chunks +7 lines, -8 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTemplateElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/DragData.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/platform/Pasteboard.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
do-not-use
7 years, 3 months ago (2013-09-04 17:42:08 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-04 17:49:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23453033/1
7 years, 3 months ago (2013-09-04 18:29:24 UTC) #3
commit-bot: I haz the power
Change committed as 157237
7 years, 3 months ago (2013-09-04 19:43:13 UTC) #4
do-not-use
dglazkov@, if you have comments / idea about this part of my description, please let ...
7 years, 3 months ago (2013-09-04 20:05:58 UTC) #5
dglazkov
7 years, 3 months ago (2013-09-04 20:22:01 UTC) #6
Message was sent while issue was closed.
+morrita,hayato who probably know this code better than I do.

Powered by Google App Engine
This is Rietveld 408576698