Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 23453032: Chrome.BrowserCrashDumpAttempts needs to account for multiple dumps from the same browser process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/breakpad_win.cc ('K') | « chrome/app/breakpad_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc
index b356a00dbb3d2c85966f560613760558055b2810..e30eb5ef60917b61bdfb50d591d58b5a77620c89 100644
--- a/chrome/browser/metrics/metrics_service.cc
+++ b/chrome/browser/metrics/metrics_service.cc
@@ -815,8 +815,7 @@ void MetricsService::CountBrowserCrashDumpAttempts() {
if (regkey.GetValueNameAt(i, &temp_name) == ERROR_SUCCESS &&
regkey.ReadValueDW(temp_name.c_str(), &temp_value) == ERROR_SUCCESS) {
regkey.DeleteValue(temp_name.c_str());
- if (temp_value != 0)
- ++crash_dump_attempts;
+ crash_dump_attempts += temp_value;
}
}
UMA_HISTOGRAM_COUNTS("Chrome.BrowserCrashDumpAttempts", crash_dump_attempts);
« chrome/app/breakpad_win.cc ('K') | « chrome/app/breakpad_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698