Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 23453030: Remove obsolete global V8::has_been_fooed flags. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Remove obsolete global V8::has_been_fooed flags. R=yangguo@chromium.org BUG=v8:2744 TEST=cctest/test-api/InitializeAndDispose Committed: http://code.google.com/p/v8/source/detail?r=16563

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M src/v8.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/v8.cc View 4 chunks +1 line, -9 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +18 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
https://codereview.chromium.org/23453030/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/23453030/diff/1/test/cctest/test-api.cc#newcode179 test/cctest/test-api.cc:179: // for (int i = 0; i < 3; ...
7 years, 3 months ago (2013-09-04 13:24:29 UTC) #1
Yang
On 2013/09/04 13:24:29, Michael Starzinger wrote: > https://codereview.chromium.org/23453030/diff/1/test/cctest/test-api.cc > File test/cctest/test-api.cc (right): > > https://codereview.chromium.org/23453030/diff/1/test/cctest/test-api.cc#newcode179 ...
7 years, 3 months ago (2013-09-05 12:38:12 UTC) #2
Michael Starzinger
7 years, 3 months ago (2013-09-05 18:53:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16563 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698