Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: media/audio/audio_manager_base.cc

Issue 23453022: Add AudioManager::GetAudioOutputDeviceNames and implement for pulseaudio. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mediaCleanups
Patch Set: Add missing file. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/audio/audio_manager_base.h" 5 #include "media/audio/audio_manager_base.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/message_loop/message_loop_proxy.h" 10 #include "base/message_loop/message_loop_proxy.h"
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 dispatcher_params->dispatcher = dispatcher; 281 dispatcher_params->dispatcher = dispatcher;
282 output_dispatchers_.push_back(dispatcher_params); 282 output_dispatchers_.push_back(dispatcher_params);
283 return new AudioOutputProxy(dispatcher.get()); 283 return new AudioOutputProxy(dispatcher.get());
284 #endif // defined(OS_IOS) 284 #endif // defined(OS_IOS)
285 } 285 }
286 286
287 void AudioManagerBase::ShowAudioInputSettings() { 287 void AudioManagerBase::ShowAudioInputSettings() {
288 } 288 }
289 289
290 void AudioManagerBase::GetAudioInputDeviceNames( 290 void AudioManagerBase::GetAudioInputDeviceNames(
291 media::AudioDeviceNames* device_names) { 291 AudioDeviceNames* device_names) {
292 }
293
294 void AudioManagerBase::GetAudioOutputDeviceNames(
295 AudioDeviceNames* device_names) {
296 // TODO(joi): Remove this and keep pure virtual once implemented everywhere.
297 NOTREACHED() << "Not implemented on this platform.";
tommi (sloooow) - chröme 2013/09/03 15:57:15 NOTIMPLEMENTED?
Jói 2013/09/04 09:11:04 Done.
292 } 298 }
293 299
294 void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) { 300 void AudioManagerBase::ReleaseOutputStream(AudioOutputStream* stream) {
295 DCHECK(stream); 301 DCHECK(stream);
296 // TODO(xians) : Have a clearer destruction path for the AudioOutputStream. 302 // TODO(xians) : Have a clearer destruction path for the AudioOutputStream.
297 // For example, pass the ownership to AudioManager so it can delete the 303 // For example, pass the ownership to AudioManager so it can delete the
298 // streams. 304 // streams.
299 --num_output_streams_; 305 --num_output_streams_;
300 delete stream; 306 delete stream;
301 } 307 }
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 return GetPreferredOutputStreamParameters(AudioParameters()); 388 return GetPreferredOutputStreamParameters(AudioParameters());
383 } 389 }
384 390
385 AudioParameters AudioManagerBase::GetInputStreamParameters( 391 AudioParameters AudioManagerBase::GetInputStreamParameters(
386 const std::string& device_id) { 392 const std::string& device_id) {
387 NOTREACHED(); 393 NOTREACHED();
388 return AudioParameters(); 394 return AudioParameters();
389 } 395 }
390 396
391 } // namespace media 397 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698