Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tests/language/string_optimizations_test.dart

Issue 23453003: Optimizations on String.concat and String.toString need to make sure the receiver is not null. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/string_optimizations_test.dart
===================================================================
--- tests/language/string_optimizations_test.dart (revision 0)
+++ tests/language/string_optimizations_test.dart (revision 0)
@@ -0,0 +1,27 @@
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for dart2js's type inferrer, that used to not
+// correclty infer optional named parameters.
+
+import "package:expect/expect.dart";
+import "compiler_annotations.dart";
+
+@DontInline()
+foo({path}) {
+ () => 42;
+ return path.toString();
+}
+
+@DontInline()
+bar({path}) {
+ () => 42;
+ return path;
+}
+
+main() {
+ var a = [foo(path: '42'), foo(), 42, bar(path: '54')];
+ Expect.isTrue(a[1] is String);
+ Expect.throws(() => bar().concat('54'), (e) => e is NoSuchMethodError);
+}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698