Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2345293002: UMA metrics for measuring first input after first paint renamed. (Closed)

Created:
4 years, 3 months ago by sahel
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UMA metrics for measuring first input after first paint renamed. BUG=479009 Committed: https://crrev.com/89e88e32b8330234e13d2f9edd9799b8dc9ee942 Cr-Commit-Position: refs/heads/master@{#419252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
sahel
4 years, 3 months ago (2016-09-16 16:42:52 UTC) #4
Bryan McQuade
LGTM, thank you again for this change!
4 years, 3 months ago (2016-09-16 16:44:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345293002/1
4 years, 3 months ago (2016-09-16 17:43:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/261197)
4 years, 3 months ago (2016-09-16 17:52:44 UTC) #11
sahel
@Steven: Please review the Histograms.xml file.
4 years, 3 months ago (2016-09-16 17:59:19 UTC) #14
Steven Holte
lgtm
4 years, 3 months ago (2016-09-16 18:53:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345293002/1
4 years, 3 months ago (2016-09-16 19:34:47 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 19:40:56 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 19:44:16 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89e88e32b8330234e13d2f9edd9799b8dc9ee942
Cr-Commit-Position: refs/heads/master@{#419252}

Powered by Google App Engine
This is Rietveld 408576698