aura: Allow platform to choose how it retrieves ICCProfile.

aura: Allow platform to choose how it retrieves ICCProfile.

In mus, the client should get the ICCProfile from the mus server,
instead of from the native platform. So get the ICCProfile from
a virtual function so that the platform can override it.

BUG=647510
Committed: https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c
Cr-Commit-Position: refs/heads/master@{#419410}

[sadrul, 2016-09-16 16:26:41]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 16:27:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-09-16 16:27:21]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2016-09-16 17:06:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 17:06:50]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-16 17:30:09]

https://codereview.chromium.org/2345283002/diff/1/ui/aura/window_tree_host.h
File ui/aura/window_tree_host.h (right):

https://codereview.chromium.org/2345283002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:224: virtual gfx::ICCProfile
GetICCProfileForCurrentDisplay();
Shouldn't this be protected?

[sadrul, 2016-09-16 17:52:17]

https://codereview.chromium.org/2345283002/diff/1/ui/aura/window_tree_host.h
File ui/aura/window_tree_host.h (right):

https://codereview.chromium.org/2345283002/diff/1/ui/aura/window_tree_host.h#...
ui/aura/window_tree_host.h:224: virtual gfx::ICCProfile
GetICCProfileForCurrentDisplay();
On 2016/09/16 17:30:08, sky wrote:
> Shouldn't this be protected?

The subclasses do not have to call this function [yet, anyway]. So I believe
this can be private.

[sky, 2016-09-16 18:34:37]

But they are overriding it, which seems weird to be private then, no?

[sadrul, 2016-09-17 01:14:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 01:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-09-17 01:19:13]

On 2016/09/16 18:34:37, sky wrote:
> But they are overriding it, which seems weird to be private then, no?

Done.

[commit-bot: I haz the power, 2016-09-17 02:02:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:02:08]

Dry run: This issue passed the CQ dry run.

[sky, 2016-09-18 16:07:10]

Thanks! LGTM

[sadrul, 2016-09-19 01:30:10]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-09-19 01:30:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 02:15:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-19 02:17:46]

Description was changed from

==========
aura: Allow platform to choose how it retrieves ICCProfile.

In mus, the client should get the ICCProfile from the mus server,
instead of from the native platform. So get the ICCProfile from
a virtual function so that the platform can override it.

BUG=647510
==========

to

==========
aura: Allow platform to choose how it retrieves ICCProfile.

In mus, the client should get the ICCProfile from the mus server,
instead of from the native platform. So get the ICCProfile from
a virtual function so that the platform can override it.

BUG=647510

Committed: https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c
Cr-Commit-Position: refs/heads/master@{#419410}
==========

[commit-bot: I haz the power, 2016-09-19 02:17:47]

Patchset 2 (id:??) landed as
https://crrev.com/a384b41d38cbab98d445c4ee205756a8f7a29f1c
Cr-Commit-Position: refs/heads/master@{#419410}