Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: src/inspector/StringUtil.h

Issue 2345263003: [inspector] provide more usefull error message for non serializable value (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/inspector/InjectedScript.cpp ('k') | src/inspector/StringUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/StringUtil.h
diff --git a/src/inspector/StringUtil.h b/src/inspector/StringUtil.h
index 3a69454d95ee3d077275ba4a338ec66cac8a488b..63ffebbcce5263748f092815b0661f381303558b 100644
--- a/src/inspector/StringUtil.h
+++ b/src/inspector/StringUtil.h
@@ -37,7 +37,8 @@ std::unique_ptr<protocol::Value> parseJSON(const String16& json);
} // namespace protocol
-std::unique_ptr<protocol::Value> toProtocolValue(v8::Local<v8::Context>,
+std::unique_ptr<protocol::Value> toProtocolValue(protocol::String* errorString,
+ v8::Local<v8::Context>,
v8::Local<v8::Value>,
int maxDepth = 1000);
« no previous file with comments | « src/inspector/InjectedScript.cpp ('k') | src/inspector/StringUtil.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698