Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: src/inspector/V8DebuggerAgentImpl.cpp

Issue 2345263003: [inspector] provide more usefull error message for non serializable value (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/inspector/InjectedScript.cpp ('K') | « src/inspector/StringUtil.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/V8DebuggerAgentImpl.cpp
diff --git a/src/inspector/V8DebuggerAgentImpl.cpp b/src/inspector/V8DebuggerAgentImpl.cpp
index 58bcd610c3cdcf163be85753bffea2f7de8b9380..1bd4ae5833d17d3b104ac04b55f169e562dfce0c 100644
--- a/src/inspector/V8DebuggerAgentImpl.cpp
+++ b/src/inspector/V8DebuggerAgentImpl.cpp
@@ -1014,7 +1014,8 @@ std::unique_ptr<Array<CallFrame>> V8DebuggerAgentImpl::currentCallFrames(
protocol::ErrorSupport errorSupport;
std::unique_ptr<Array<CallFrame>> callFrames = Array<CallFrame>::parse(
- toProtocolValue(debuggerContext, objects).get(), &errorSupport);
+ toProtocolValue(errorString, debuggerContext, objects).get(),
dgozman 2016/09/19 17:35:06 Should check the result of toProtocolValue and ret
kozy 2016/09/20 15:34:27 Done.
+ &errorSupport);
if (hasInternalError(errorString, !callFrames))
return Array<CallFrame>::create();
return callFrames;
« src/inspector/InjectedScript.cpp ('K') | « src/inspector/StringUtil.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698