third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp - Issue 2345233004: Reuse cc::PictureLayers when possible for SPv2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

Issue 2345233004: Reuse cc::PictureLayers when possible for SPv2. (Closed)

Patch Set: none Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 ('k') | third_party/WebKit/Source/core/paint/PaintInvalidator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

index 6e7506549b9a0a030e35bc4fb50a72fe05005ae9..c204c43bb647b78868f63e69646eca333684cba2 100644

--- a/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp

@@ -28,7 +28,9 @@ void PaintInvalidationCapableScrollableArea::willRemoveScrollbar(Scrollbar& scro

static LayoutRect scrollControlPaintInvalidationRect(const IntRect& scrollControlRect, const LayoutBox& box, const PaintInvalidatorContext& context)

{

LayoutRect paintInvalidationRect(scrollControlRect);

- if (!paintInvalidationRect.isEmpty())

+ // No need to apply any paint offset. Scroll controls paint in a different transform space than their contained box

+ // (the scrollbarPaintOffset transform node).

+ if (!paintInvalidationRect.isEmpty() && !RuntimeEnabledFeatures::slimmingPaintV2Enabled())

context.mapLocalRectToPaintInvalidationBacking(box, paintInvalidationRect);

return paintInvalidationRect;

}