Issue 23452049: Allow IfBuilder's to join existing (captured) continuations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23452049: Allow IfBuilder's to join existing (captured) continuations. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer

Modified:
7 years, 3 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Allow IfBuilder's to join existing (captured) continuations. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16857

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -1 line)			Patch
	M	src/hydrogen.h	View	1	3 chunks	+52 lines, -1 line	0 comments	Download
	M	src/hydrogen.cc	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Hey Michael, Here's the "join continuation" support for the IfBuilder I've told you about yesterday. ...

7 years, 3 months ago (2013-09-20 07:27:44 UTC) #1

mvstanton

LGTM with nit: could you just add a good overview comment to the JoinContinuation method? ...

7 years, 3 months ago (2013-09-20 10:02:07 UTC) #2

Benedikt Meurer

7 years, 3 months ago (2013-09-20 10:47:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16857 (presubmit successful).