Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 23452047: Collect garbage before running mjsunit/fast-prototype (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Collect garbage before running mjsunit/fast-prototype When not using a snapshot, after turning on i18n, there's just enough garbage after creating a context to trigger gc at the wrong moment. Since the test uses natives syntax to access information that would otherwise be hidden from javascript, this makes the test fail BUG=none R=mstarzinger@chromium.org TEST=mjsunit/fast-prototype passes on ia32.release with no snapshot Committed: https://code.google.com/p/v8/source/detail?r=16830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/mjsunit/fast-prototype.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-19 13:05:58 UTC) #1
Michael Starzinger
LGTM.
7 years, 3 months ago (2013-09-19 13:11:25 UTC) #2
jochen (gone - plz use gerrit)
7 years, 3 months ago (2013-09-19 13:12:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16830.

Powered by Google App Engine
This is Rietveld 408576698