Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 23452044: Sigh. Lower-case the "k" in ChromiumWebkit for the layout tests upload for Android. (Closed)

Created:
7 years, 3 months ago by Dirk Pranke
Modified:
7 years, 3 months ago
Reviewers:
Isaac (away), ojan
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Sigh. Lower-case the "k" in ChromiumWebkit for the layout tests upload for Android. One more change after r223770. Hopefully this one's the ticket. (Build fix). TBR=ojan@chromium.org, ilevy@chromium.org BUG=293928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/buildbot/bb_device_steps.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
7 years, 3 months ago (2013-09-18 19:18:49 UTC) #1
ojan
lgtm On Wed, Sep 18, 2013 at 12:18 PM, <dpranke@chromium.org> wrote: > Reviewers: Isaac, ojan, ...
7 years, 3 months ago (2013-09-18 19:23:58 UTC) #2
Dirk Pranke
Committed patchset #1 manually as r223912.
7 years, 3 months ago (2013-09-18 19:24:47 UTC) #3
Isaac (away)
lgtm
7 years, 3 months ago (2013-09-18 21:55:47 UTC) #4
Dirk Pranke
7 years, 3 months ago (2013-09-18 22:05:47 UTC) #5
Message was sent while issue was closed.
Happily, things are finally working :).

Powered by Google App Engine
This is Rietveld 408576698