sdk/lib/_internal/compiler/implementation/compile_time_constants.dart - Issue 23452038: Check cycles in redirecting factories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 23452038: Check cycles in redirecting factories. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

diff --git a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

index f9339f03d14b769e54198083f3a195aaa8f06ce0..2c57097e4d0780419cdd47cfe35030b2a5d72ba0 100644

--- a/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

+++ b/sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

@@ -713,7 +713,12 @@ class CompileTimeConstantEvaluator extends Visitor {

type = constructor.computeTargetType(compiler, type);

}

- constructor = constructor.redirectionTarget;

+ FunctionElement target = constructor.redirectionTarget;

+ if (target != null) {

+ constructor = target;

+ } else {

+ constructor = constructor.defaultImplementation;

+ }

ClassElement classElement = constructor.getEnclosingClass();

// The constructor must be an implementation to ensure that field

// initializers are handled correctly.

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/elements/modelx.dart » ('j') | no next file with comments »