dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart - Issue 23452029: Address comments from CL 23304012.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 23452029: Address comments from CL 23304012. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

index 2c18645024ee3c37c357dd0dec2c741eb06874c7..12bc0928561e8fcf47f51576c7b65095f313dc28 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

@@ -169,6 +169,7 @@ class CodeEmitterNoEvalTask extends CodeEmitterTask {

primitives, const SourceString('printString'));

String printHelperName = namer.isolateAccess(printHelper);

mainBuffer.add('''

+// The following only works on V8 when run with option "--allow-natives-syntax".

if (typeof $printHelperName === "function") {

$printHelperName("Size of global object: "

+ String(Object.getOwnPropertyNames(properties).length)