Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 23452008: Remove experimental.rlz extension api completely (Closed)

Created:
7 years, 3 months ago by pals
Modified:
7 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove experimental.rlz extension api completely BUG=278556 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224090

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -700 lines) Patch
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/rlz/rlz_extension_api.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/rlz/rlz_extension_api.cc View 1 chunk +0 lines, -229 lines 0 comments Download
D chrome/browser/rlz/rlz_extension_apitest.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/common/extensions/api/experimental_rlz.json View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/rlz/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/rlz/test.js View 1 chunk +0 lines, -164 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
pals
+rogerta : c/b/rlz +isherman : tools/ +mpcomplete : e/b/e Please review.
7 years, 3 months ago (2013-09-02 12:39:14 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Might also want to delete http://www.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/rlz-api
7 years, 3 months ago (2013-09-03 15:10:20 UTC) #2
Matt Perry
Love seeing all the deleted code! LGTM
7 years, 3 months ago (2013-09-03 19:11:29 UTC) #3
Ilya Sherman
histograms.xml lgtm
7 years, 3 months ago (2013-09-03 22:40:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23452008/1
7 years, 3 months ago (2013-09-04 05:17:20 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/extension_api.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-04 05:17:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23452008/1
7 years, 3 months ago (2013-09-04 16:32:25 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/extension_api.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-04 16:32:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23452008/13001
7 years, 3 months ago (2013-09-06 08:48:58 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/common/extensions/api/extension_api.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-06 08:49:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23452008/18001
7 years, 3 months ago (2013-09-19 05:39:52 UTC) #11
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=26300
7 years, 3 months ago (2013-09-19 05:55:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/23452008/18001
7 years, 3 months ago (2013-09-19 06:07:46 UTC) #13
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 09:26:31 UTC) #14
Message was sent while issue was closed.
Change committed as 224090

Powered by Google App Engine
This is Rietveld 408576698