ui/native_theme/native_theme_dark_aura.cc - Issue 2345183002: Views: Draw Textfield selected text in gray when top-level Widget loses focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_dark_aura.cc

Issue 2345183002: Views: Draw Textfield selected text in gray when top-level Widget loses focus.

Patch Set: Fix lifetime issues with BorderView's widget_ and address review comments. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/native_theme/native_theme_dark_aura.cc

diff --git a/ui/native_theme/native_theme_dark_aura.cc b/ui/native_theme/native_theme_dark_aura.cc

index f40f64c654bd48061b9941c4b791d450a093a2c8..63837b2fdc0beef4fb5b069cc8af8b558cd36d9d 100644

--- a/ui/native_theme/native_theme_dark_aura.cc

+++ b/ui/native_theme/native_theme_dark_aura.cc

@@ -118,6 +118,7 @@ SkColor NativeThemeDarkAura::GetSystemColor(ColorId color_id) const {

case kColorId_LinkDisabled:

case kColorId_TextfieldReadOnlyColor:

case kColorId_TextfieldReadOnlyBackground:

+ case kColorId_TextfieldSelectionBackgroundUnfocused:

msw 2016/11/09 02:08:53 It seems odd that any textfield colors aren't defi

case kColorId_TooltipBackground:

case kColorId_TooltipText:

case kColorId_TreeBackground: