Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: ui/gfx/render_text.h

Issue 2345183002: Views: Draw Textfield selected text in gray when top-level Widget loses focus.
Patch Set: Fix lifetime issues with BorderView's widget_ and address review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text.h
diff --git a/ui/gfx/render_text.h b/ui/gfx/render_text.h
index a5bda21596a73b196ffa6dd98fa54d336cbc1964..25ac0f8469a7b2ec51322908b2a3cf7f58f2c641 100644
--- a/ui/gfx/render_text.h
+++ b/ui/gfx/render_text.h
@@ -256,13 +256,15 @@ class GFX_EXPORT RenderText {
SkColor selection_color() const { return selection_color_; }
void set_selection_color(SkColor color) { selection_color_ = color; }
- SkColor selection_background_focused_color() const {
- return selection_background_focused_color_;
+ SkColor selection_background_color() const {
+ return selection_background_color_;
}
- void set_selection_background_focused_color(SkColor color) {
- selection_background_focused_color_ = color;
+ void set_selection_background_color(SkColor color) {
+ selection_background_color_ = color;
}
+ void set_draw_text_selection(bool draw) { draw_text_selection_ = draw; }
+
bool focused() const { return focused_; }
void set_focused(bool focused) { focused_ = focused; }
@@ -758,7 +760,10 @@ class GFX_EXPORT RenderText {
SkColor selection_color_;
// The background color used for drawing the selection when focused.
- SkColor selection_background_focused_color_;
+ SkColor selection_background_color_;
+
+ // Whether to draw the selected text regardless of focus.
msw 2016/11/09 02:08:53 nit: "Whether to draw the unfocused text selection
+ bool draw_text_selection_;
msw 2016/11/09 02:08:53 nit: Consider renaming this for clarity, since it
// The focus state of the text.
bool focused_;

Powered by Google App Engine
This is Rietveld 408576698