Views: Draw Textfield selected text in gray when top-level Widget loses focus.

ui/views/focus/focus_traversal_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/macros.h"
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 114 matching lines @@
 
  private:
   FocusSearch* focus_search_;
 };
 
 // BorderView is a view containing a native window with its own view hierarchy.
 // It is interesting to test focus traversal from a view hierarchy to an inner
 // view hierarchy.
 class BorderView : public NativeViewHost {
  public:
-  explicit BorderView(View* child) : child_(child), widget_(NULL) {
+  explicit BorderView(View* child) : child_(child) {
     DCHECK(child);
     SetFocusBehavior(FocusBehavior::NEVER);
   }
 
-  ~BorderView() override {}
-
   virtual internal::RootView* GetContentsRootView() {
     return static_cast<internal::RootView*>(widget_->GetRootView());
   }
 
   FocusTraversable* GetFocusTraversable() override {
     return static_cast<internal::RootView*>(widget_->GetRootView());
   }
 
   void ViewHierarchyChanged(
       const ViewHierarchyChangedDetails& details) override {
     NativeViewHost::ViewHierarchyChanged(details);
 
     if (details.child == this && details.is_add) {
       if (!widget_) {
-        widget_ = new Widget;
+        widget_.reset(new Widget);
         Widget::InitParams params(Widget::InitParams::TYPE_CONTROL);
         params.parent = details.parent->GetWidget()->GetNativeView();
+        params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
         widget_->Init(params);
         widget_->SetFocusTraversableParentView(this);
         widget_->SetContentsView(child_);
       }
 
       // We have been added to a view hierarchy, attach the native view.
       Attach(widget_->GetNativeView());
       // Also update the FocusTraversable parent so the focus traversal works.
       static_cast<internal::RootView*>(widget_->GetRootView())->
           SetFocusTraversableParent(GetWidget()->GetFocusTraversable());
     }
   }
 
  private:
   View* child_;
-  Widget* widget_;
+  std::unique_ptr<Widget> widget_;

[Patti Lor, 2016/11/08 04:00:27]

BorderView uses a Widget as convenient way to create a NativeWindow, but it sets
another Widget's NativeWindow as the parent while also holding a weak pointer.
To safely cleanup, use a unique_ptr instead. This avoids problems when the
parent NativeWindow cleans up its native children.

[tapted, 2016/11/08 23:35:19]

See also http://crbug.com/663418 about this - let's land this part separately as
a fix for 663418 and get input from sky on it

[msw, 2016/11/09 02:08:53]

Scott already has context on this nuanced issue; so that sounds good.
That said, could this be a plain member, instead of using unique_ptr?

[Patti Lor, 2016/11/10 07:29:09]

Reverted this file, changes are in https://codereview.chromium.org/2482193003/,
which has landed already :)

Making |widget_| a normal member means there will need to be an explicit delete
widget_; in the BorderView destructor.

[msw, 2016/11/10 18:45:01]

If you just do |Widget widget_;|, it'll be automatically constructed in the ctor
and automatically destructed in the dtor, right? No need to delete.

[Patti Lor, 2016/11/10 23:37:48]

Oops, sorry - I didn't realise you meant a non-pointer by "plain member"! You're
totally right, I will change this in the next patchset.

 
   DISALLOW_COPY_AND_ASSIGN(BorderView);
 };
 
 }  // namespace
 
 class FocusTraversalTest : public FocusManagerTest {
  public:
   ~FocusTraversalTest() override;
 
@@ skipping 694 matching lines @@
   GetFocusManager()->AdvanceFocus(false);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 
   // Advance backwards from the root node.
   GetFocusManager()->ClearFocus();
   GetFocusManager()->AdvanceFocus(true);
   EXPECT_FALSE(GetFocusManager()->GetFocusedView());
 }
 
 }  // namespace views