Views: Draw Textfield selected text in gray when top-level Widget loses focus.

ui/views/controls/textfield/textfield.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 #define UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 11 matching lines @@
 #include "ui/base/models/simple_menu_model.h"
 #include "ui/base/touch/touch_editing_controller.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "ui/gfx/font_list.h"
 #include "ui/gfx/range/range.h"
 #include "ui/gfx/selection_model.h"
 #include "ui/gfx/text_constants.h"
 #include "ui/views/context_menu_controller.h"
 #include "ui/views/controls/textfield/textfield_model.h"
 #include "ui/views/drag_controller.h"
+#include "ui/views/focus/focus_manager.h"
 #include "ui/views/selection_controller.h"
 #include "ui/views/selection_controller_delegate.h"
 #include "ui/views/view.h"
 #include "ui/views/word_lookup_client.h"
 
 namespace views {
 
 class MenuRunner;
 class Painter;
 class TextfieldController;
 
 // A views/skia textfield implementation. No platform-specific code is used.
 class VIEWS_EXPORT Textfield : public View,
                                public TextfieldModel::Delegate,
                                public ContextMenuController,
                                public DragController,
+                               public FocusChangeListener,

[msw, 2016/11/09 02:14:54]

Would it make sense (and/or be easier to manage) to make Textfield a
WidgetObserver and handle OnWidgetActivationChanged and check for the focus
state (instead of being a FocusChangeListener)

[Patti Lor, 2016/11/10 07:29:09]

Ah, I hadn't considered using OnWidgetActivationChanged. From first glance, I
think the code might be quite similar - the hard part is probably just when to
add the Textfield as a observer, which will probably just go into
(Native)ViewHierarchyChanged() like now. It might make more sense though (and we
could get rid of the |focus_manager_| pointer, I think). I'll try it and see if
anything weird breaks.

                                public WordLookupClient,
                                public SelectionControllerDelegate,
                                public ui::TouchEditable,
                                public ui::TextInputClient {
  public:
   // The textfield's class name.
   static const char kViewClassName[];
 
   // The preferred size of the padding to be used around textfield text.
   static const int kTextPadding;
@@ skipping 75 matching lines @@
   void SetSelectionTextColor(SkColor color);
   void UseDefaultSelectionTextColor();
 
   // Gets/sets the selection background color to be used when painting the
   // Textfield. Call UseDefaultSelectionBackgroundColor() to restore the default
   // system color.
   SkColor GetSelectionBackgroundColor() const;
   void SetSelectionBackgroundColor(SkColor color);
   void UseDefaultSelectionBackgroundColor();
 
+  // Gets the selection background color for use when the Textfield was the last
+  // to be focused in a widget.
+  SkColor GetUnfocusedSelectionBackgroundColor() const;
+
   // Set drop shadows underneath the text.
   void SetShadows(const gfx::ShadowValues& shadows);
 
   // Gets/Sets whether or not the cursor is enabled.
   bool GetCursorEnabled() const;
   void SetCursorEnabled(bool enabled);
 
   // Gets/Sets the fonts used when rendering the text within the Textfield.
   const gfx::FontList& GetFontList() const;
   void SetFontList(const gfx::FontList& font_list);
@@ skipping 84 matching lines @@
   int OnDragUpdated(const ui::DropTargetEvent& event) override;
   void OnDragExited() override;
   int OnPerformDrop(const ui::DropTargetEvent& event) override;
   void OnDragDone() override;
   void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
   bool HandleAccessibleAction(const ui::AXActionData& action_data) override;
   void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
   bool GetNeedsNotificationWhenVisibleBoundsChange() const override;
   void OnVisibleBoundsChanged() override;
   void OnEnabledChanged() override;
+  void ViewHierarchyChanged(
+      const ViewHierarchyChangedDetails& details) override;
+  void NativeViewHierarchyChanged() override;
   void OnPaint(gfx::Canvas* canvas) override;
   void OnFocus() override;
   void OnBlur() override;
   gfx::Point GetKeyboardContextMenuLocation() override;
   void OnNativeThemeChanged(const ui::NativeTheme* theme) override;
 
   // TextfieldModel::Delegate overrides:
   void OnCompositionTextConfirmedOrCleared() override;
 
   // ContextMenuController overrides:
   void ShowContextMenuForView(View* source,
                               const gfx::Point& point,
                               ui::MenuSourceType source_type) override;
 
   // DragController overrides:
   void WriteDragDataForView(View* sender,
                             const gfx::Point& press_pt,
                             ui::OSExchangeData* data) override;
   int GetDragOperationsForView(View* sender, const gfx::Point& p) override;
   bool CanStartDragForView(View* sender,
                            const gfx::Point& press_pt,
                            const gfx::Point& p) override;
 
+  // FocusChangeListener overrides:
+  void OnWillChangeFocus(View* focused_before, View* focused_now) override;
+  void OnDidChangeFocus(View* focused_before, View* focused_now) override;
+
   // WordLookupClient overrides:
   bool GetDecoratedWordAtPoint(const gfx::Point& point,
                                gfx::DecoratedText* decorated_word,
                                gfx::Point* baseline_point) override;
 
   // SelectionControllerDelegate overrides:
   bool HasTextBeingDragged() const override;
 
   // ui::TouchEditable overrides:
   void SelectRect(const gfx::Point& start, const gfx::Point& end) override;
@@ skipping 77 matching lines @@
   int GetViewHeight() const override;
   int GetViewWidth() const override;
   int GetDragSelectionDelay() const override;
   void OnBeforePointerAction() override;
   void OnAfterPointerAction(bool text_changed, bool selection_changed) override;
   // Callers within Textfield should call UpdateAfterChange depending on the
   // return value.
   bool PasteSelectionClipboard() override;
   void UpdateSelectionClipboard() override;
 
+  // Adds this Textfield as a FocusChangeListener based on |add_as_listener|.
+  // Always removes this Textfield as a listener of the previously listened-to
+  // focus manager (if it exists) before this happens.
+  void ObserveWidgetFocusChanges(bool add_as_listener);
+
   // Updates the painted background color.
   void UpdateBackgroundColor();
 
   // Updates the border per the state of |invalid_|.
   void UpdateBorder();
 
   // Does necessary updates when the text and/or cursor position changes.
   void UpdateAfterChange(bool text_changed, bool cursor_changed);
 
   // A callback function to periodically update the cursor node_data.
@@ skipping 81 matching lines @@
   // what overriding color values should be used instead.
   bool use_default_text_color_;
   bool use_default_background_color_;
   bool use_default_selection_text_color_;
   bool use_default_selection_background_color_;
   SkColor text_color_;
   SkColor background_color_;
   SkColor selection_text_color_;
   SkColor selection_background_color_;
 
+  // In cases where the Widget is deleted before the Textfield, there is no
+  // longer a way to retrieve the FocusManager. It's still needed to remove this
+  // Textfield as an observer, so keep a reference to the FocusManager this
+  // Textfield is listening to, if any.
+  FocusManager* focus_manager_;
+
   // Text to display when empty.
   base::string16 placeholder_text_;
 
   // Placeholder text color.
   // TODO(estade): remove this when Harmony/MD is default.
   SkColor placeholder_text_color_;
 
   // True when the contents are deemed unacceptable and should be indicated as
   // such.
   bool invalid_;
@@ skipping 51 matching lines @@
 
   // Used to bind callback functions to this object.
   base::WeakPtrFactory<Textfield> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Textfield);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TEXTFIELD_TEXTFIELD_H_