Views: Draw Textfield selected text in gray when top-level Widget loses focus.

ui/views/controls/textfield/textfield_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/textfield.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <set>
@@ skipping 312 matching lines @@
     target_->set_controller(this);
   }
 
   views::Textfield* target() { return target_.get(); }
 
   // views::TextfieldController:
   bool HandleKeyEvent(views::Textfield* sender,
                       const ui::KeyEvent& key_event) override {
     if (target_)
       target_->OnBlur();
+    // Removal of the Textfield must be done manually here since
+    // Textfield::ViewHierarchyChanged() needs to be executed. Allowing View to
+    // do it in its destructor instead (which calls RemoveChildView()) means
+    // only View::ViewHierarchyChanged() is called.

[tapted, 2016/10/31 00:30:25]

This is a great comment, and a nice find. Things like this are really hard to
diagnose.

[Patti Lor, 2016/11/02 03:19:48]

Thank you! :))

+    target_->parent()->RemoveChildView(target_.get());
     target_.reset();
     return false;
   }
 
  private:
   std::unique_ptr<views::Textfield> target_;
 };
 
 base::string16 GetClipboardText(ui::ClipboardType type) {
   base::string16 text;
@@ skipping 2662 matching lines @@
 
   textfield_->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
   ui::AXViewState state_protected;
   textfield_->GetAccessibleState(&state_protected);
   EXPECT_EQ(ui::AX_ROLE_TEXT_FIELD, state_protected.role);
   EXPECT_EQ(ASCIIToUTF16("********"), state_protected.value);
   EXPECT_TRUE(state_protected.HasStateFlag(ui::AX_STATE_PROTECTED));
 }
 
 }  // namespace views