webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h - Issue 2345163002: Several minor improvements of DirectX capturer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

Issue 2345163002: Several minor improvements of DirectX capturer (Closed)

Patch Set: Resolve review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

diff --git a/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h b/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

index 020ca640edba19769610ce5dae4beea487e32110..0d5b13479609b20e60222b4074bc60ba887b6fbb 100644

--- a/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

+++ b/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

@@ -111,7 +111,7 @@ class DxgiOutputDuplicator {

// Returns a DesktopRect in the coordinate of |offset|.

DesktopRect TargetRect(DesktopRect rect, DesktopVector offset);

- const D3dDevice& device_;

+ const D3dDevice device_;

const Microsoft::WRL::ComPtr<IDXGIOutput1> output_;

const DesktopRect desktop_rect_;

Microsoft::WRL::ComPtr<IDXGIOutputDuplication> duplication_;