Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

Issue 2345163002: Several minor improvements of DirectX capturer (Closed)
Patch Set: Remove DPI awareness changes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h
diff --git a/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h b/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h
index 020ca640edba19769610ce5dae4beea487e32110..0d5b13479609b20e60222b4074bc60ba887b6fbb 100644
--- a/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h
+++ b/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h
@@ -111,7 +111,7 @@ class DxgiOutputDuplicator {
// Returns a DesktopRect in the coordinate of |offset|.
DesktopRect TargetRect(DesktopRect rect, DesktopVector offset);
- const D3dDevice& device_;
+ const D3dDevice device_;
Jamie 2016/09/17 00:49:30 No need for const if it's not a reference. Please
Hzj_jie 2016/09/19 19:09:57 Updated the description. I remember we have discus
Jamie 2016/09/19 19:16:07 Thanks for the detailed rationale. If the style gu
const Microsoft::WRL::ComPtr<IDXGIOutput1> output_;
const DesktopRect desktop_rect_;
Microsoft::WRL::ComPtr<IDXGIOutputDuplication> duplication_;

Powered by Google App Engine
This is Rietveld 408576698