Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2345153002:
cheets: add wallpaper observer to arc_wallpaper_service. (Closed)
|
Created:
4 years, 3 months ago by Muyuan Modified:
4 years, 3 months ago CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), davemoore+watch_chromium.org, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncheets: add wallpaper observer to arc_wallpaper_service.
ArcWallpaperService now observes wallpaper change
and notifies Android, which will use it to broadcast
ACTION_WALLPAPER_CHANGED.
Test=Change wallpaper with CrOS wallpaper picker
and verify with Android app that listens wallpaper
changed broadcast.
Bug=642465
Committed: https://crrev.com/063754cbba42aaa1f7ea51e16328c5d60971127d
Cr-Commit-Position: refs/heads/master@{#419303}
Patch Set 1 #
Total comments: 9
Patch Set 2 : add null check to wallpaper controller during destruction and checks whether wallpaper instance is … #Patch Set 3 : change null check in ~ArcWallpaperService(), modified instance version check / null check to follow… #
Total comments: 4
Patch Set 4 : delete wallpaper observer in OnInstanceClosed() and ~ArcWallpaperService #
Total comments: 8
Patch Set 5 : minor edits on coding style in response to comment #
Total comments: 6
Patch Set 6 : minor edits in ArcWallpaperService::GetWallpaperController() in response to comment. #Patch Set 7 : minor edits in response to comment #Patch Set 8 : cheets: switch arc wallpaper layout to CENTER_CROPPED. #Messages
Total messages: 33 (9 generated)
muyuanli@chromium.org changed reviewers: + lhchavez@chromium.org, yusukes@google.com
The corresponding Android changes are: ag/1450669/ and ag/1450766/
Description was changed from ========== cheets: add wallpaper observer to arc_wallpaper_service. ArcWallpaperService now observes wallpaper change and notifies Android, which will use it to broadcast ACTION_WALLPAPER_CHANGED. Test=Change wallpaper with CrOS wallpaper picker and verify with Android app that listens wallpaper changed broadcast. Bug=642465 ========== to ========== cheets: add wallpaper observer to arc_wallpaper_service. ArcWallpaperService now observes wallpaper change and notifies Android, which will use it to broadcast ACTION_WALLPAPER_CHANGED. Test=Change wallpaper with CrOS wallpaper picker and verify with Android app that listens wallpaper changed broadcast. Bug=642465 ==========
muyuanli@chromium.org changed reviewers: + xiaohuic@chromium.org
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); what if instance() is null? It's probably better to follow the pattern found elsewhere: https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... (although you probably don't need the error code part, nor the part where you check for ArcBridgeService's existence, since you are guaranteed that it will exist by virtue of being an ArcService).
lhchavez@chromium.org changed reviewers: + rickyz@chromium.org
+rickyz@ for .mojom change.
yusukes@chromium.org changed reviewers: + yusukes@chromium.org - yusukes@google.com
-yusukes@g, +yusukes@c
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:85: ash::WmShell::Get()->wallpaper_controller()->RemoveObserver(this); You need null check(s). See the trybot (browser_test) failure.
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); On 2016/09/16 00:01:58, Luis Héctor Chávez wrote: > what if instance() is null? It's probably better to follow the pattern found > elsewhere: > > https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... > > (although you probably don't need the error code part, nor the part where you > check for ArcBridgeService's existence, since you are guaranteed that it will > exist by virtue of being an ArcService). The observer is registered in OnInstanceReady, so can I assume that when OnWallpaperChanged is called, the instance will never be null?
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); On 2016/09/16 16:30:05, muyuanli wrote: > On 2016/09/16 00:01:58, Luis Héctor Chávez wrote: > > what if instance() is null? It's probably better to follow the pattern found > > elsewhere: > > > > > https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... > > > > (although you probably don't need the error code part, nor the part where you > > check for ArcBridgeService's existence, since you are guaranteed that it will > > exist by virtue of being an ArcService). > > The observer is registered in OnInstanceReady, so can I assume that when > OnWallpaperChanged is called, the instance will never be null? You can't assume that: What happens if the other side closes the connection afterwards? However, if you also add the OnInstanceClosed() override and unregister the wallpaper observer there, you _can_ assume that. Still, the point about following the pattern found elsewhere stands.
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:85: ash::WmShell::Get()->wallpaper_controller()->RemoveObserver(this); On 2016/09/16 00:45:19, Yusuke Sato wrote: > You need null check(s). See the trybot (browser_test) failure. Done. https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); On 2016/09/16 16:34:02, Luis Héctor Chávez wrote: > On 2016/09/16 16:30:05, muyuanli wrote: > > On 2016/09/16 00:01:58, Luis Héctor Chávez wrote: > > > what if instance() is null? It's probably better to follow the pattern found > > > elsewhere: > > > > > > > > > https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... > > > > > > (although you probably don't need the error code part, nor the part where > you > > > check for ArcBridgeService's existence, since you are guaranteed that it > will > > > exist by virtue of being an ArcService). > > > > The observer is registered in OnInstanceReady, so can I assume that when > > OnWallpaperChanged is called, the instance will never be null? > > You can't assume that: What happens if the other side closes the connection > afterwards? > > However, if you also add the OnInstanceClosed() override and unregister the > wallpaper observer there, you _can_ assume that. > > Still, the point about following the pattern found elsewhere stands. Done.
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); On 2016/09/16 17:35:16, muyuanli wrote: > On 2016/09/16 16:34:02, Luis Héctor Chávez wrote: > > On 2016/09/16 16:30:05, muyuanli wrote: > > > On 2016/09/16 00:01:58, Luis Héctor Chávez wrote: > > > > what if instance() is null? It's probably better to follow the pattern > found > > > > elsewhere: > > > > > > > > > > > > > > https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... > > > > > > > > (although you probably don't need the error code part, nor the part where > > you > > > > check for ArcBridgeService's existence, since you are guaranteed that it > > will > > > > exist by virtue of being an ArcService). > > > > > > The observer is registered in OnInstanceReady, so can I assume that when > > > OnWallpaperChanged is called, the instance will never be null? > > > > You can't assume that: What happens if the other side closes the connection > > afterwards? > > > > However, if you also add the OnInstanceClosed() override and unregister the > > wallpaper observer there, you _can_ assume that. > > > > Still, the point about following the pattern found elsewhere stands. > > Done. Should I remove the wallpaper observer when the instance is null and hope it will be re-registered in OnInstanceReady?
mojom lgtm
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); On 2016/09/16 17:37:22, muyuanli wrote: > On 2016/09/16 17:35:16, muyuanli wrote: > > On 2016/09/16 16:34:02, Luis Héctor Chávez wrote: > > > On 2016/09/16 16:30:05, muyuanli wrote: > > > > On 2016/09/16 00:01:58, Luis Héctor Chávez wrote: > > > > > what if instance() is null? It's probably better to follow the pattern > > found > > > > > elsewhere: > > > > > > > > > > > > > > > > > > > > https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... > > > > > > > > > > (although you probably don't need the error code part, nor the part > where > > > you > > > > > check for ArcBridgeService's existence, since you are guaranteed that it > > > will > > > > > exist by virtue of being an ArcService). > > > > > > > > The observer is registered in OnInstanceReady, so can I assume that when > > > > OnWallpaperChanged is called, the instance will never be null? > > > > > > You can't assume that: What happens if the other side closes the connection > > > afterwards? > > > > > > However, if you also add the OnInstanceClosed() override and unregister the > > > wallpaper observer there, you _can_ assume that. > > > > > > Still, the point about following the pattern found elsewhere stands. > > > > Done. > > Should I remove the wallpaper observer when the instance is null and hope it > will be re-registered in OnInstanceReady? So what I'm saying is: a) Change CheckWallpaperInstanceVersion to be mojom::WallpaperInstance* GetWallpaperInstance(uint32_t min_version). This is for consistency with other services that do the same. I'll probably make this a feature of the InstanceHolder given that everybody seems to need it. I'll try to post that change for review later, so you can wait for me to land it if you want. b) Additionally you should remove the observer in the OnInstanceClosed(). This is to avoid getting notifications when you can't do anything about it and avoid spurious logs.
https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:133: arc_bridge_service()->wallpaper()->instance()->OnWallpaperChanged(); On 2016/09/16 17:49:14, Luis Héctor Chávez wrote: > On 2016/09/16 17:37:22, muyuanli wrote: > > On 2016/09/16 17:35:16, muyuanli wrote: > > > On 2016/09/16 16:34:02, Luis Héctor Chávez wrote: > > > > On 2016/09/16 16:30:05, muyuanli wrote: > > > > > On 2016/09/16 00:01:58, Luis Héctor Chávez wrote: > > > > > > what if instance() is null? It's probably better to follow the pattern > > > found > > > > > > elsewhere: > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cs.chromium.org/chromium/src/components/arc/intent_helper/arc_intent_... > > > > > > > > > > > > (although you probably don't need the error code part, nor the part > > where > > > > you > > > > > > check for ArcBridgeService's existence, since you are guaranteed that > it > > > > will > > > > > > exist by virtue of being an ArcService). > > > > > > > > > > The observer is registered in OnInstanceReady, so can I assume that when > > > > > OnWallpaperChanged is called, the instance will never be null? > > > > > > > > You can't assume that: What happens if the other side closes the > connection > > > > afterwards? > > > > > > > > However, if you also add the OnInstanceClosed() override and unregister > the > > > > wallpaper observer there, you _can_ assume that. > > > > > > > > Still, the point about following the pattern found elsewhere stands. > > > > > > Done. > > > > Should I remove the wallpaper observer when the instance is null and hope it > > will be re-registered in OnInstanceReady? > > So what I'm saying is: > > a) Change CheckWallpaperInstanceVersion to be mojom::WallpaperInstance* > GetWallpaperInstance(uint32_t min_version). This is for consistency with other > services that do the same. I'll probably make this a feature of the > InstanceHolder given that everybody seems to need it. I'll try to post that > change for review later, so you can wait for me to land it if you want. > b) Additionally you should remove the observer in the OnInstanceClosed(). This > is to avoid getting notifications when you can't do anything about it and avoid > spurious logs. Done.
https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:136: ash::WmShell::Get()->wallpaper_controller()->RemoveObserver(this); It's better to do this in the OnInstanceClosed() rather than here.
https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:136: ash::WmShell::Get()->wallpaper_controller()->RemoveObserver(this); On 2016/09/16 19:58:11, Luis Héctor Chávez wrote: > It's better to do this in the OnInstanceClosed() rather than here. I see. So here is a question: Is there a guarantee that Android side will be torn down before CrOS side? In other words, is OnInstanceClosed() always guaranteed to be called prior to ~ArcWallpaperService()? I'm asking this because if it's true, the removal of WallpaperObserver in ~ArcWallpaperService() could be moved here.
https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:136: ash::WmShell::Get()->wallpaper_controller()->RemoveObserver(this); On 2016/09/16 20:19:08, muyuanli wrote: > On 2016/09/16 19:58:11, Luis Héctor Chávez wrote: > > It's better to do this in the OnInstanceClosed() rather than here. > > I see. So here is a question: > Is there a guarantee that Android side will be torn down before CrOS side? In > other words, is OnInstanceClosed() always guaranteed to be called prior to > ~ArcWallpaperService()? I'm asking this because if it's true, the removal of > WallpaperObserver in ~ArcWallpaperService() could be moved here. There are cases where Android outlives Chrome, but are error cases. I'd rather have two places where the observer is removed (because the second removal is a no-op): one in OnInstanceClosed() (for symmetry with OnInstanceReady()) and one in the destructor (for safety). If you omit the latter, the destructor of the ObserverList will DCHECK since not all Observers were removed.
https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/40001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:136: ash::WmShell::Get()->wallpaper_controller()->RemoveObserver(this); On 2016/09/16 20:27:37, Luis Héctor Chávez wrote: > On 2016/09/16 20:19:08, muyuanli wrote: > > On 2016/09/16 19:58:11, Luis Héctor Chávez wrote: > > > It's better to do this in the OnInstanceClosed() rather than here. > > > > I see. So here is a question: > > Is there a guarantee that Android side will be torn down before CrOS side? In > > other words, is OnInstanceClosed() always guaranteed to be called prior to > > ~ArcWallpaperService()? I'm asking this because if it's true, the removal of > > WallpaperObserver in ~ArcWallpaperService() could be moved here. > > There are cases where Android outlives Chrome, but are error cases. I'd rather > have two places where the observer is removed (because the second removal is a > no-op): one in OnInstanceClosed() (for symmetry with OnInstanceReady()) and one > in the destructor (for safety). If you omit the latter, the destructor of the > ObserverList will DCHECK since not all Observers were removed. Done.
lgtm with nits. Thanks! https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:143: if (!instance) { nit: you can elide the braces. Same in all the other one-line if blocks. https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:149: ash::WallpaperController* ArcWallpaperService::GetWallpaperController() { This doesn't need to be a method. A standalone function in the anonymous namespace suffices.
https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:143: if (!instance) { On 2016/09/16 21:05:56, Luis Héctor Chávez wrote: > nit: you can elide the braces. Same in all the other one-line if blocks. Done. https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:149: ash::WallpaperController* ArcWallpaperService::GetWallpaperController() { On 2016/09/16 21:05:56, Luis Héctor Chávez wrote: > This doesn't need to be a method. A standalone function in the anonymous > namespace suffices. Done.
https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:75: if (wm_shell && wm_shell->wallpaper_controller()) { Forgot this one too: In general you want to do if (!good_state) return nullptr; // good state can be assumed from now on. (also, elide braces :P)
lgtm with nits https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:7: #include <string> same (line 7-8) https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.h (right): https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.h:10: #include <memory> nit: this seems unnecessary (line 10-12) https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:75: if (wm_shell && wm_shell->wallpaper_controller()) { no {} https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:149: if (!instance) { same https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:166: if (!instance) { same
https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:7: #include <string> On 2016/09/16 21:23:50, Yusuke Sato wrote: > same (line 7-8) Done. https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.h (right): https://codereview.chromium.org/2345153002/diff/60001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.h:10: #include <memory> On 2016/09/16 21:23:50, Yusuke Sato wrote: > nit: this seems unnecessary (line 10-12) Done. https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... File chrome/browser/chromeos/arc/arc_wallpaper_service.cc (right): https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:75: if (wm_shell && wm_shell->wallpaper_controller()) { On 2016/09/16 21:23:50, Yusuke Sato wrote: > no {} Done. https://codereview.chromium.org/2345153002/diff/80001/chrome/browser/chromeos... chrome/browser/chromeos/arc/arc_wallpaper_service.cc:166: if (!instance) { On 2016/09/16 21:23:50, Yusuke Sato wrote: > same Done.
The CQ bit was checked by muyuanli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org, lhchavez@chromium.org, yusukes@chromium.org Link to the patchset: https://codereview.chromium.org/2345153002/#ps120001 (title: "minor edits in response to comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== cheets: add wallpaper observer to arc_wallpaper_service. ArcWallpaperService now observes wallpaper change and notifies Android, which will use it to broadcast ACTION_WALLPAPER_CHANGED. Test=Change wallpaper with CrOS wallpaper picker and verify with Android app that listens wallpaper changed broadcast. Bug=642465 ========== to ========== cheets: add wallpaper observer to arc_wallpaper_service. ArcWallpaperService now observes wallpaper change and notifies Android, which will use it to broadcast ACTION_WALLPAPER_CHANGED. Test=Change wallpaper with CrOS wallpaper picker and verify with Android app that listens wallpaper changed broadcast. Bug=642465 ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== cheets: add wallpaper observer to arc_wallpaper_service. ArcWallpaperService now observes wallpaper change and notifies Android, which will use it to broadcast ACTION_WALLPAPER_CHANGED. Test=Change wallpaper with CrOS wallpaper picker and verify with Android app that listens wallpaper changed broadcast. Bug=642465 ========== to ========== cheets: add wallpaper observer to arc_wallpaper_service. ArcWallpaperService now observes wallpaper change and notifies Android, which will use it to broadcast ACTION_WALLPAPER_CHANGED. Test=Change wallpaper with CrOS wallpaper picker and verify with Android app that listens wallpaper changed broadcast. Bug=642465 Committed: https://crrev.com/063754cbba42aaa1f7ea51e16328c5d60971127d Cr-Commit-Position: refs/heads/master@{#419303} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/063754cbba42aaa1f7ea51e16328c5d60971127d Cr-Commit-Position: refs/heads/master@{#419303} |
