Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: media/gpu/ipc/common/media_messages.h

Issue 2345123002: Attach color space information to hardware decoded NV12 video frames. (Closed)
Patch Set: comments addressed + compile fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/ipc/common/media_messages.h
diff --git a/media/gpu/ipc/common/media_messages.h b/media/gpu/ipc/common/media_messages.h
index b48b3bdadd07981cddd2ca19cd770a83080b898d..8c4093c6a7a8e263e0bc423366dca7db77c91e52 100644
--- a/media/gpu/ipc/common/media_messages.h
+++ b/media/gpu/ipc/common/media_messages.h
@@ -13,6 +13,7 @@
#include "media/video/jpeg_decode_accelerator.h"
#include "media/video/video_decode_accelerator.h"
#include "media/video/video_encode_accelerator.h"
+#include "ui/gfx/ipc/color/gfx_param_traits.h"
#include "ui/gfx/ipc/gfx_param_traits.h"
#define IPC_MESSAGE_START MediaMsgStart
@@ -107,13 +108,16 @@ IPC_MESSAGE_ROUTED5(AcceleratedVideoDecoderHostMsg_ProvidePictureBuffers,
IPC_MESSAGE_ROUTED1(AcceleratedVideoDecoderHostMsg_DismissPictureBuffer,
int32_t) /* Picture buffer ID */
+typedef std::pair<bool, bool> BoolPair;
+
// Decoder reports that a picture is ready.
IPC_MESSAGE_ROUTED5(AcceleratedVideoDecoderHostMsg_PictureReady,
- int32_t, /* Picture buffer ID */
- int32_t, /* Bitstream buffer ID */
- gfx::Rect, /* Visible rectangle */
- bool, /* Buffer is HW overlay capable */
- bool) /* VDA updated picture size */
+ int32_t, /* Picture buffer ID */
+ int32_t, /* Bitstream buffer ID */
+ gfx::Rect, /* Visible rectangle */
+ gfx::ColorSpace, /* color space */
+ BoolPair) /* Buffer is HW overlay capable */
sandersd (OOO until July 31) 2016/09/16 21:54:13 I'm going to call out that I don't like this, even
hubbe 2016/09/21 22:04:26 Acknowledged.
+ /* VDA updated picture size */
// Confirm decoder has been flushed.
IPC_MESSAGE_ROUTED0(AcceleratedVideoDecoderHostMsg_FlushDone)

Powered by Google App Engine
This is Rietveld 408576698