media/filters/gpu_video_decoder.cc - Issue 2345123002: Attach color space information to hardware decoded NV12 video frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 2345123002: Attach color space information to hardware decoded NV12 video frames. (Closed)

Patch Set: comments addressed + compile fixes Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index 375a64940d1602f6c174a26801bfa70be138800b..678ba6f12839bfc660111e47bc8da97a3a266c71 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -607,6 +607,7 @@ void GpuVideoDecoder::PictureReady(const media::Picture& picture) {

weak_factory_.GetWeakPtr(), factories_,

picture.picture_buffer_id(), pb.texture_ids())),

pb.size(), visible_rect, natural_size, timestamp));

+ frame->set_color_space(picture.color_space());

sandersd (OOO until July 31) 2016/09/16 21:54:13 This is pretty clearly wrong given the next line ;

hubbe 2016/09/21 22:04:25 Done.

if (!frame) {

DLOG(ERROR) << "Create frame failed for: " << picture.picture_buffer_id();

NotifyError(VideoDecodeAccelerator::PLATFORM_FAILURE);