media/gpu/android_video_decode_accelerator.cc - Issue 2345123002: Attach color space information to hardware decoded NV12 video frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/android_video_decode_accelerator.cc

Issue 2345123002: Attach color space information to hardware decoded NV12 video frames. (Closed)

Patch Set: minor bugfix Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/gpu/android_video_decode_accelerator.cc

diff --git a/media/gpu/android_video_decode_accelerator.cc b/media/gpu/android_video_decode_accelerator.cc

index 8d1bc5f73706aa52d044f56e46772792d93ccff6..55eb7384b1f4486e15c99fd70a30b5ef22048ef8 100644

--- a/media/gpu/android_video_decode_accelerator.cc

+++ b/media/gpu/android_video_decode_accelerator.cc

@@ -828,8 +828,9 @@ void AndroidVideoDecodeAccelerator::SendDecodedFrameToClient(

const bool allow_overlay = picture_buffer_manager_.ArePicturesOverlayable();

UMA_HISTOGRAM_BOOLEAN("Media.AVDA.FrameSentAsOverlay", allow_overlay);

+ // TODO(hubbe): Insert the correct color space. http://crbug.com/647725

Picture picture(picture_buffer_id, bitstream_id, gfx::Rect(size_),

- allow_overlay);

+ gfx::ColorSpace(), allow_overlay);

picture.set_size_changed(size_changed);

// Notify picture ready before calling UseCodecBufferForPictureBuffer() since

« no previous file with comments | « media/filters/h264_parser.cc ('k') | media/gpu/dxva_picture_buffer_win.h » ('j') | no next file with comments »