Attach color space information to hardware decoded NV12 video frames.

media/filters/h264_parser.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/h264_parser.h"
 
 #include <limits>
 #include <memory>
 
 #include "base/logging.h"
@@ skipping 798 matching lines @@
       sps->sar_height = kTableSarHeight[aspect_ratio_idc];
     }
   }
 
   int data;
   // Read and ignore overscan and video signal type info.
   READ_BOOL_OR_RETURN(&data);  // overscan_info_present_flag
   if (data)
     READ_BOOL_OR_RETURN(&data);  // overscan_appropriate_flag
 
+  // Default color space information.

[sandersd (OOO until July 31), 2016/09/16 00:55:20]

I'd prefer that these were in an else block.

Note that ParseVUIParameters() is not called if there is no VUI. It may be
better to provide |video_signal_type_present_flag| instead. Then you can do what
I did for |visible_rect| and provide helper methods that do the interpretation
and use Chrome types.

Other alternatives exist, you would just be the first to need them.

[Pawel Osciak, 2016/09/16 04:37:39]

+1. Also, in that case I'd also include video_format for consistency, even if
not used right now.

[hubbe, 2016/09/16 18:03:29]

Done.

[hubbe, 2016/09/16 18:03:30]

Done.

+  sps->full_range = true;

[sandersd (OOO until July 31), 2016/09/16 00:55:20]

Should default to false.

[hubbe, 2016/09/16 18:03:30]

Done.

+  sps->primary_idc = 2;
+  sps->transfer_idc = 2;
+  sps->matrix_idc = 2;
+
   READ_BOOL_OR_RETURN(&data);  // video_signal_type_present_flag
   if (data) {
     READ_BITS_OR_RETURN(3, &data);  // video_format
-    READ_BOOL_OR_RETURN(&data);  // video_full_range_flag
+    READ_BOOL_OR_RETURN(&sps->full_range);  // video_full_range_flag

[Pawel Osciak, 2016/09/16 04:37:39]

s/full_range/video_full_range_flag/

If possible, please keep names exactly as in the spec, makes it easier to search
in the code and look up in the spec.

[hubbe, 2016/09/16 18:03:30]

Done.

     READ_BOOL_OR_RETURN(&data);  // colour_description_present_flag
-    if (data)
-      READ_BITS_OR_RETURN(24, &data);  // color description syntax elements
+    if (data) {
+      // color description syntax elements
+      READ_BITS_OR_RETURN(8, &sps->primary_idc);

[Pawel Osciak, 2016/09/16 04:37:39]

s/primary_idc/colour_primaries/

[hubbe, 2016/09/16 18:03:30]

Done.

+      READ_BITS_OR_RETURN(8, &sps->transfer_idc);

[Pawel Osciak, 2016/09/16 04:37:39]

transfer_characteristics

[hubbe, 2016/09/16 18:03:30]

Done.

+      READ_BITS_OR_RETURN(8, &sps->matrix_idc);

[Pawel Osciak, 2016/09/16 04:37:39]

matrix_coefficients

[hubbe, 2016/09/16 18:03:30]

Done.

+    }
   }
 
   READ_BOOL_OR_RETURN(&data);  // chroma_loc_info_present_flag
   if (data) {
     READ_UE_OR_RETURN(&data);  // chroma_sample_loc_type_top_field
     READ_UE_OR_RETURN(&data);  // chroma_sample_loc_type_bottom_field
   }
 
   // Read and ignore timing info.
   READ_BOOL_OR_RETURN(&data);  // timing_info_present_flag
@@ skipping 622 matching lines @@
 
     default:
       DVLOG(4) << "Unsupported SEI message";
       break;
   }
 
   return kOk;
 }
 
 }  // namespace media