Issue 23451055: cc: Always use SetNeedsBeginFrame to request the next BeginFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23451055: cc: Always use SetNeedsBeginFrame to request the next BeginFrame (Closed)

Created:
7 years, 3 months ago by brianderson

Modified:
7 years, 3 months ago

Reviewers:
danakj, Sami, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, nduca, boliu, joth, jdduke (slow), dnicoara

Base URL:
http://git.chromium.org/chromium/src.git@pollForDrawTriggers

Visibility:
Public.

More Reviews

Description

cc: Always use SetNeedsBeginFrame to request the next BeginFrame This avoids relying on SwapBuffers to implicitly trigger the next BeginFrame. Only a single code path is used to request the next BeginFrame now: SetNeedsBeginFrame(true). This avoids issues where OutputSurface subclasses might not call OutputSurface::DidSwap() when they need to or when we early out a swap request and don't actually swap anything. BUG=289755

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+75 lines, -37 lines)			Patch
cc/output/output_surface.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
cc/output/output_surface_unittest.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download
cc/scheduler/scheduler.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
cc/scheduler/scheduler.cc	View	5 chunks	+10 lines, -28 lines	0 comments	Download
cc/scheduler/scheduler_state_machine.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
cc/scheduler/scheduler_unittest.cc	View	8 chunks	+54 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brianderson

This addresses dana's comments in: https://codereview.chromium.org/23767011 And address a lot of enne's comments in: https://codereview.chromium.org/23796002 ...

7 years, 3 months ago (2013-09-12 23:28:14 UTC) #1

enne (OOO)

I think rietveld might just be on the fritz today. I see a lot of ...

7 years, 3 months ago (2013-09-13 00:41:11 UTC) #2

brianderson

Trying again: https://codereview.chromium.org/23892022

7 years, 3 months ago (2013-09-13 01:35:40 UTC) #3

brianderson

7 years, 3 months ago (2013-09-13 01:35:40 UTC) #4

Trying again:
https://codereview.chromium.org/23892022

Expand Messages | Collapse Messages