Source/core/page/animation/KeyframeAnimation.cpp - Issue 23451031: Fix AnimationBase::fractionalTime() to handle a scale of infinity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/animation/KeyframeAnimation.cpp

Issue 23451031: Fix AnimationBase::fractionalTime() to handle a scale of infinity (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Added expected result Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/animation/KeyframeAnimation.cpp

diff --git a/Source/core/page/animation/KeyframeAnimation.cpp b/Source/core/page/animation/KeyframeAnimation.cpp

index ad1422c7bc79f70ac95f0138afaa8e272164d9b2..5d951422f0c714292f726dc01d5d2d467f43975d 100644

--- a/Source/core/page/animation/KeyframeAnimation.cpp

+++ b/Source/core/page/animation/KeyframeAnimation.cpp

@@ -158,6 +158,8 @@ void KeyframeAnimation::fetchIntervalEndpointsForProperty(CSSPropertyID property

offset = prevKeyframe.key();

scale = 1.0 / (nextKeyframe.key() - prevKeyframe.key());

+ // A scale of infinity is handled in AnimationBase::fractionalTime().

+ ASSERT(scale >= 0 && (!std::isinf(scale) || prevIndex == nextIndex));

const TimingFunction* timingFunction = 0;

if (const CSSAnimationData* matchedAnimation = getAnimationFromStyleByName(fromStyle, name()))