Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2345103003: [parser] Minor cleanup after refactoring (Closed)

Created:
4 years, 3 months ago by nickie
Modified:
4 years, 3 months ago
Reviewers:
adamk, marja
CC:
v8-reviews_googlegroups.com, Dan Ehrenberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Minor cleanup after refactoring - Remove redundant "impl()->". - Remove NewBlock method from "impl()", exists in "factory()". - Resolve TODO comments. R=adamk@chromium.org, marja@chromium.org BUG= LOG=N Committed: https://crrev.com/cb13d50a5ab3f15d21bd40a64d37dec04b444de8 Cr-Commit-Position: refs/heads/master@{#39496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -23 lines) Patch
M src/parsing/parser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/parsing/parser-base.h View 6 chunks +9 lines, -12 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
nickie
4 years, 3 months ago (2016-09-16 14:12:19 UTC) #1
adamk
lgtm
4 years, 3 months ago (2016-09-16 20:31:39 UTC) #7
marja
lgtm
4 years, 3 months ago (2016-09-19 07:51:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345103003/1
4 years, 3 months ago (2016-09-19 08:12:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/24923)
4 years, 3 months ago (2016-09-19 08:20:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345103003/1
4 years, 3 months ago (2016-09-19 09:26:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 09:28:45 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 09:29:19 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb13d50a5ab3f15d21bd40a64d37dec04b444de8
Cr-Commit-Position: refs/heads/master@{#39496}

Powered by Google App Engine
This is Rietveld 408576698