Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2345103002: Freeze scrollbars for relayout if overflow:auto added scrollbars. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 14 matching lines...) Expand all
25 25
26 #include "core/layout/LayoutTableSection.h" 26 #include "core/layout/LayoutTableSection.h"
27 27
28 #include "core/layout/HitTestResult.h" 28 #include "core/layout/HitTestResult.h"
29 #include "core/layout/LayoutAnalyzer.h" 29 #include "core/layout/LayoutAnalyzer.h"
30 #include "core/layout/LayoutTableCell.h" 30 #include "core/layout/LayoutTableCell.h"
31 #include "core/layout/LayoutTableCol.h" 31 #include "core/layout/LayoutTableCol.h"
32 #include "core/layout/LayoutTableRow.h" 32 #include "core/layout/LayoutTableRow.h"
33 #include "core/layout/LayoutView.h" 33 #include "core/layout/LayoutView.h"
34 #include "core/layout/SubtreeLayoutScope.h" 34 #include "core/layout/SubtreeLayoutScope.h"
35 #include "core/paint/PaintLayerScrollableArea.h"
36 #include "core/paint/TableSectionPainter.h" 35 #include "core/paint/TableSectionPainter.h"
37 #include "wtf/HashSet.h" 36 #include "wtf/HashSet.h"
38 #include <algorithm> 37 #include <algorithm>
39 #include <limits> 38 #include <limits>
40 39
41 namespace blink { 40 namespace blink {
42 41
43 using namespace HTMLNames; 42 using namespace HTMLNames;
44 43
45 // This variable is used to balance the memory consumption vs the paint invalida tion time on big tables. 44 // This variable is used to balance the memory consumption vs the paint invalida tion time on big tables.
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
776 ASSERT(!uniqueCells.contains(cell)); 775 ASSERT(!uniqueCells.contains(cell));
777 uniqueCells.add(cell); 776 uniqueCells.add(cell);
778 #endif 777 #endif
779 778
780 rowSpanCells.append(cell); 779 rowSpanCells.append(cell);
781 lastRowSpanCell = cell; 780 lastRowSpanCell = cell;
782 } 781 }
783 } 782 }
784 783
785 if (cell->rowIndex() == r && cell->hasOverrideLogicalContentHeig ht()) { 784 if (cell->rowIndex() == r && cell->hasOverrideLogicalContentHeig ht()) {
786 PaintLayerScrollableArea::FreezeScrollbarsScope freezeScroll bars;
787 cell->clearIntrinsicPadding(); 785 cell->clearIntrinsicPadding();
788 cell->clearOverrideSize(); 786 cell->clearOverrideSize();
789 cell->forceChildLayout(); 787 cell->forceChildLayout();
790 } 788 }
791 789
792 if (cell->rowSpan() == 1) 790 if (cell->rowSpan() == 1)
793 m_rowPos[r + 1] = std::max(m_rowPos[r + 1], m_rowPos[r] + ce ll->logicalHeightForRowSizing()); 791 m_rowPos[r + 1] = std::max(m_rowPos[r + 1], m_rowPos[r] + ce ll->logicalHeightForRowSizing());
794 792
795 // Find out the baseline. The baseline is set on the first row i n a rowSpan. 793 // Find out the baseline. The baseline is set on the first row i n a rowSpan.
796 if (cell->rowIndex() == r) 794 if (cell->rowIndex() == r)
(...skipping 951 matching lines...) Expand 10 before | Expand all | Expand 10 after
1748 // Repeating table headers are painted once per fragmentation page/column. T his does not go through the regular fragmentation machinery, 1746 // Repeating table headers are painted once per fragmentation page/column. T his does not go through the regular fragmentation machinery,
1749 // so we need special code to expand the invalidation rect to contain all po sitions of the header in all columns. 1747 // so we need special code to expand the invalidation rect to contain all po sitions of the header in all columns.
1750 // Note that this is in flow thread coordinates, not visual coordinates. The enclosing LayoutFlowThread will convert to visual coordinates. 1748 // Note that this is in flow thread coordinates, not visual coordinates. The enclosing LayoutFlowThread will convert to visual coordinates.
1751 if (table()->header() == this && hasRepeatingHeaderGroup()) 1749 if (table()->header() == this && hasRepeatingHeaderGroup())
1752 rect.setHeight(table()->logicalHeight()); 1750 rect.setHeight(table()->logicalHeight());
1753 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rec t, flags); 1751 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rec t, flags);
1754 } 1752 }
1755 1753
1756 1754
1757 } // namespace blink 1755 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698