Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: trunk/src/content/public/test/browser_test_utils.h

Issue 23451030: Revert 222168 "Add a CodeToNativeKeycode helper that converts UI..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/public/test/browser_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/public/test/browser_test_utils.h
===================================================================
--- trunk/src/content/public/test/browser_test_utils.h (revision 222198)
+++ trunk/src/content/public/test/browser_test_utils.h (working copy)
@@ -79,38 +79,13 @@
const gfx::Point& point);
// Sends a key press asynchronously.
-// The native code of the key event will be set to InvalidNativeKeycode().
-// |key_code| alone is good enough for scenarios that only need the char
-// value represented by a key event and not the physical key on the keyboard
-// or the keyboard layout.
-// For scenarios such as chromoting that need the native code,
-// SimulateKeyPressWithCode should be used.
void SimulateKeyPress(WebContents* web_contents,
- ui::KeyboardCode key_code,
+ ui::KeyboardCode key,
bool control,
bool shift,
bool alt,
bool command);
-// Sends a key press asynchronously.
-// |code| specifies the UIEvents (aka: DOM4Events) value of the key:
-// https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm
-// The native code of the key event will be set based on |code|.
-// See ui/base/keycodes/vi usb_keycode_map.h for mappings between |code|
-// and the native code.
-// Examples of the various codes:
-// key_code: VKEY_A
-// code: "KeyA"
-// native key code: 0x001e (for Windows).
-// native key code: 0x0026 (for Linux).
-void SimulateKeyPressWithCode(WebContents* web_contents,
- ui::KeyboardCode key_code,
- const char* code,
- bool control,
- bool shift,
- bool alt,
- bool command);
-
// Allow ExecuteScript* methods to target either a WebContents or a
// RenderViewHost. Targetting a WebContents means executing script in the
// RenderViewHost returned by WebContents::GetRenderViewHost(), which is the
« no previous file with comments | « no previous file | trunk/src/content/public/test/browser_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698