Split Jinja-related CodeGeneratorV8 guts into a separate class.

Split Jinja-related CodeGeneratorV8 guts into a separate class.

* Introduces CodeGeneratorBase, which contains most of the
  Jinja-related plumbing.
* Shifts some common functions along with it into a new file.

R=yukishiino,bashi
BUG=603795
TEST=Tools/Scripts/run-bindings-tests

Committed: https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d
Cr-Commit-Position: refs/heads/master@{#419643}

[dglazkov, 2016-09-17 00:38:37]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 00:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 02:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:12:35]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-09-17 03:51:05]

PTAL.

[blink-reviews, 2016-09-17 05:58:10]

LGTM on my side, but bashi@ might want to take a look.


2016/09/17 午後0:51 <dglazkov@chromium.org>:
>
> Reviewers: bashi, yukishiino
> CL: https://codereview.chromium.org/2345083004/
>
> Message:
> PTAL.
>
> Description:
> Split Jinja-related CodeGeneratorV8 guts into a separate class.
>
> * Introduces CodeGeneratorBase, which contains most of the
> Jinja-related plumbing.
> * Shifts some common functions along with it into a new file.
>
> R=yukishiino,bashi
> BUG=603795
> TEST=Tools/Scripts/run-bindings-tests
>
> Affected files (+205, -182 lines):
> M third_party/WebKit/Source/bindings/scripts/BUILD.gn
> A third_party/WebKit/Source/bindings/scripts/code_generator.py
> M third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
> M third_party/WebKit/Source/bindings/scripts/scripts.gni
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-09-17 05:58:11]

LGTM on my side, but bashi@ might want to take a look.


2016/09/17 午後0:51 <dglazkov@chromium.org>:
>
> Reviewers: bashi, yukishiino
> CL: https://codereview.chromium.org/2345083004/
>
> Message:
> PTAL.
>
> Description:
> Split Jinja-related CodeGeneratorV8 guts into a separate class.
>
> * Introduces CodeGeneratorBase, which contains most of the
> Jinja-related plumbing.
> * Shifts some common functions along with it into a new file.
>
> R=yukishiino,bashi
> BUG=603795
> TEST=Tools/Scripts/run-bindings-tests
>
> Affected files (+205, -182 lines):
> M third_party/WebKit/Source/bindings/scripts/BUILD.gn
> A third_party/WebKit/Source/bindings/scripts/code_generator.py
> M third_party/WebKit/Source/bindings/scripts/code_generator_v8.py
> M third_party/WebKit/Source/bindings/scripts/scripts.gni
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[haraken, 2016-09-17 08:16:24]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-17 08:16:24]

LGTM (from a correct account)

[bashi, 2016-09-19 23:22:16]

bashi@chromium.org changed reviewers:
+ bashi@chromium.org

[bashi, 2016-09-19 23:22:17]

lgtm

lkawai@ FYI: This will conflict with your CL
https://codereview.chromium.org/2312093003/

[dglazkov, 2016-09-19 23:30:33]

On 2016/09/19 at 23:22:17, bashi wrote:
> lgtm
> 
> lkawai@ FYI: This will conflict with your CL
https://codereview.chromium.org/2312093003/

I am happy to wait+rebase. LMK what you would like to do.

[bashi, 2016-09-19 23:53:38]

Please land this first :) We need to fix win failures.

[bashi, 2016-09-20 00:27:49]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:29:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:57:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-20 01:59:46]

Description was changed from

==========
Split Jinja-related CodeGeneratorV8 guts into a separate class.

* Introduces CodeGeneratorBase, which contains most of the
  Jinja-related plumbing.
* Shifts some common functions along with it into a new file.

R=yukishiino,bashi
BUG=603795
TEST=Tools/Scripts/run-bindings-tests
==========

to

==========
Split Jinja-related CodeGeneratorV8 guts into a separate class.

* Introduces CodeGeneratorBase, which contains most of the
  Jinja-related plumbing.
* Shifts some common functions along with it into a new file.

R=yukishiino,bashi
BUG=603795
TEST=Tools/Scripts/run-bindings-tests

Committed: https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d
Cr-Commit-Position: refs/heads/master@{#419643}
==========

[commit-bot: I haz the power, 2016-09-20 01:59:47]

Patchset 1 (id:??) landed as
https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d
Cr-Commit-Position: refs/heads/master@{#419643}

[Yuki, 2016-09-20 04:42:11]

Description was changed from

==========
Split Jinja-related CodeGeneratorV8 guts into a separate class.

* Introduces CodeGeneratorBase, which contains most of the
  Jinja-related plumbing.
* Shifts some common functions along with it into a new file.

R=yukishiino,bashi
BUG=603795
TEST=Tools/Scripts/run-bindings-tests

Committed: https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d
Cr-Commit-Position: refs/heads/master@{#419643}
==========

to

==========
Split Jinja-related CodeGeneratorV8 guts into a separate class.

* Introduces CodeGeneratorBase, which contains most of the
  Jinja-related plumbing.
* Shifts some common functions along with it into a new file.

R=yukishiino,bashi
BUG=603795
TEST=Tools/Scripts/run-bindings-tests

Committed: https://crrev.com/8889114b8767fda91d4fc4c5f49eb5034395ee5d
Cr-Commit-Position: refs/heads/master@{#419643}
==========

[Yuki, 2016-09-20 04:42:11]

yukishiino@chromium.org changed reviewers:
+ yukishiino@chromium.org
- yukishiino@chromium.or