dart2js: run dartfmt on tests

tests/compiler/dart2js_extra/for_in_test.dart

Index: tests/compiler/dart2js_extra/for_in_test.dart
diff --git a/tests/compiler/dart2js_extra/for_in_test.dart b/tests/compiler/dart2js_extra/for_in_test.dart
index eb5de79631add7e594ccd104548ac41f55a4c188..46093d8d423161461397136f736b236f67e31da8 100644
--- a/tests/compiler/dart2js_extra/for_in_test.dart
+++ b/tests/compiler/dart2js_extra/for_in_test.dart
@@ -37,7 +37,9 @@ class MyIterable<T> extends IterableBase<T> {
 class MyListIterator<T> implements Iterator<T> {
   final List<T> values;
   int index;
-  MyListIterator(List<T> values) : this.values = values, index = -1;
+  MyListIterator(List<T> values)
+      : this.values = values,
+        index = -1;
 
   bool moveNext() => ++index < values.length;
   T get current => (0 <= index && index < values.length) ? values[index] : null;
@@ -48,13 +50,17 @@ void main() {
   testIterator([], new MyIterable([]));
   testIterator([1], [1]);
   testIterator([1], new MyIterable([1]));
-  testIterator([1,2,3], [1,2,3]);
-  testIterator([1,2,3], new MyIterable([1,2,3]));
-  testIterator(["a","b","c"], ["a","b","c"]);
-  testIterator(["a","b","c"], new MyIterable(["a","b","c"]));
+  testIterator([1, 2, 3], [1, 2, 3]);
+  testIterator([1, 2, 3], new MyIterable([1, 2, 3]));
+  testIterator(["a", "b", "c"], ["a", "b", "c"]);
+  testIterator(["a", "b", "c"], new MyIterable(["a", "b", "c"]));
 
   // Several nested for-in's.
-  for (var x in [[["a"]]]) {
+  for (var x in [
+    [
+      ["a"]

[Siggi Cherem (dart-lang), 2016/09/16 20:55:24]

so sad... so sad... maybe file a bug on dartfmt?

[Bob Nystrom, 2016/09/16 21:16:03]

dartfmt just isn't tuned for unusual code like this. It's hard to make weird
code like language tests look nicer without making real-world code look worse.

[Harry Terkelsen, 2016/09/16 21:44:04]

A similar bug exists: https://github.com/dart-lang/dart_style/issues/501

+    ]
+  ]) {
     for (var y in x) {
       for (var z in y) {
         Expect.equals("a", z);
@@ -63,7 +69,10 @@ void main() {
   }
 
   // Simultaneous iteration of the same iterable.
-  for (var iterable in [[1,2,3], new MyIterable([1,2,3])]) {
+  for (var iterable in [
+    [1, 2, 3],
+    new MyIterable([1, 2, 3])
+  ]) {
     int result = 0;
     for (var x in iterable) {
       for (var y in iterable) {
@@ -76,7 +85,7 @@ void main() {
   // Using the same variable (showing that the expression is evaluated
   // in the outer scope).
   int result = 0;
-  var x = [1,2,3];
+  var x = [1, 2, 3];
   for (var x in x) {
     result += x;
   }