Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)
Patch Set: more Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
diff --git a/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp b/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
index d3d55b91b5ec46a6777c65afd2ed95169ce7d66a..2e922a5ec97e74bf1fb12ac54d297d9ea3c45b9d 100644
--- a/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
+++ b/core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp
@@ -63,13 +63,14 @@ CFX_ByteString CPDF_PageContentGenerator::RealizeResource(
CPDF_Object* pResourceObj,
const CFX_ByteString& bsType) {
if (!m_pPage->m_pResources) {
- m_pPage->m_pResources = new CPDF_Dictionary;
+ m_pPage->m_pResources =
+ new CPDF_Dictionary(m_pDocument->GetByteStringPool());
int objnum = m_pDocument->AddIndirectObject(m_pPage->m_pResources);
m_pPage->m_pFormDict->SetReferenceFor("Resources", m_pDocument, objnum);
}
CPDF_Dictionary* pResList = m_pPage->m_pResources->GetDictFor(bsType);
if (!pResList) {
- pResList = new CPDF_Dictionary;
+ pResList = new CPDF_Dictionary(m_pDocument->GetByteStringPool());
m_pPage->m_pResources->SetFor(bsType, pResList);
}
m_pDocument->AddIndirectObject(pResourceObj);
@@ -113,7 +114,8 @@ void CPDF_PageContentGenerator::ProcessForm(CFX_ByteTextBuf& buf,
return;
}
CPDF_Stream* pStream = new CPDF_Stream(nullptr, 0, nullptr);
- CPDF_Dictionary* pFormDict = new CPDF_Dictionary;
+ CPDF_Dictionary* pFormDict =
+ new CPDF_Dictionary(m_pDocument->GetByteStringPool());
pFormDict->SetNameFor("Type", "XObject");
pFormDict->SetNameFor("Subtype", "Form");
CFX_FloatRect bbox = m_pPage->GetPageBBox();
« no previous file with comments | « no previous file | core/fpdfapi/fpdf_font/cpdf_font.cpp » ('j') | core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698