core/fxge/dib/fx_dib_engine_unittest.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxge/dib/fx_dib_engine_unittest.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: windows compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxge/dib/fx_dib_engine_unittest.cpp

diff --git a/core/fxge/dib/fx_dib_engine_unittest.cpp b/core/fxge/dib/fx_dib_engine_unittest.cpp

index 4b4063b7e56e1483e31701b6a61aa739e7818ac4..0d0fdbdca7a082372ec74eb369c5c96fa79bf52a 100644

--- a/core/fxge/dib/fx_dib_engine_unittest.cpp

+++ b/core/fxge/dib/fx_dib_engine_unittest.cpp

@@ -16,7 +16,7 @@

TEST(CStretchEngine, OverflowInCtor) {

FX_RECT clip_rect;

std::unique_ptr<CPDF_Dictionary, ReleaseDeleter<CPDF_Dictionary>> dict_obj(

- new CPDF_Dictionary);

+ new CPDF_Dictionary(CFX_WeakPtr<CFX_ByteStringPool>()));

dict_obj->SetFor("Width", new CPDF_Number(71000));

dict_obj->SetFor("Height", new CPDF_Number(12500));

std::unique_ptr<CPDF_Stream, ReleaseDeleter<CPDF_Stream>> stream(

« no previous file with comments | « core/fpdfdoc/include/cpdf_filespec.h ('k') | core/fxge/include/cfx_renderdevice.h » ('j') | no next file with comments »