core/fpdfdoc/cpdf_annotlist.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_annotlist.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: windows compile Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_annotlist.cpp

diff --git a/core/fpdfdoc/cpdf_annotlist.cpp b/core/fpdfdoc/cpdf_annotlist.cpp

index 8ab99e55d257242068bcb6599f6563eba48d46d5..38d73460efdbe69a6e2a9099de0e32d91c9e0f5c 100644

--- a/core/fpdfdoc/cpdf_annotlist.cpp

+++ b/core/fpdfdoc/cpdf_annotlist.cpp

@@ -30,7 +30,8 @@ std::unique_ptr<CPDF_Annot> CreatePopupAnnot(CPDF_Annot* pAnnot,

if (sContents.IsEmpty())

return std::unique_ptr<CPDF_Annot>();

- CPDF_Dictionary* pAnnotDict = new CPDF_Dictionary;

+ CPDF_Dictionary* pAnnotDict =

+ new CPDF_Dictionary(pDocument->GetByteStringPool());

pAnnotDict->SetNameFor("Type", "Annot");

pAnnotDict->SetNameFor("Subtype", "Popup");

pAnnotDict->SetStringFor("T", pParentDict->GetStringFor("T"));

« no previous file with comments | « core/fpdfapi/fpdf_parser/include/cpdf_document.h ('k') | core/fpdfdoc/cpdf_filespec.cpp » ('j') | no next file with comments »