fpdfsdk/fpdfppo.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfppo.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: Address Dan's concern about outliving document Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfppo.cpp

diff --git a/fpdfsdk/fpdfppo.cpp b/fpdfsdk/fpdfppo.cpp

index d901a6114304cfceb1e0c79aeb0b5de5efb86388..0a3e9714cef8d6f4aa53fe14437f67be48c8094e 100644

--- a/fpdfsdk/fpdfppo.cpp

+++ b/fpdfsdk/fpdfppo.cpp

@@ -70,7 +70,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document* pDestPDFDoc,

CPDF_Dictionary* pNewPages =

pElement ? ToDictionary(pElement->GetDirect()) : nullptr;

if (!pNewPages) {

- pNewPages = new CPDF_Dictionary;

+ pNewPages = new CPDF_Dictionary(pDestPDFDoc->GetByteStringPool());

pNewRoot->SetReferenceFor("Pages", pDestPDFDoc,

pDestPDFDoc->AddIndirectObject(pNewPages));

}