core/fpdfdoc/cpdf_filespec.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_filespec.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: Address Dan's concern about outliving document Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_filespec.cpp

diff --git a/core/fpdfdoc/cpdf_filespec.cpp b/core/fpdfdoc/cpdf_filespec.cpp

index 3176eb51af3722e43a8f4a3c461d3a0f1e9013b1..8423d66fc7ac806bc6f5be9e5c2f2efe5a30fba8 100644

--- a/core/fpdfdoc/cpdf_filespec.cpp

+++ b/core/fpdfdoc/cpdf_filespec.cpp

@@ -110,8 +110,8 @@ bool CPDF_FileSpec::GetFileName(CFX_WideString* csFileName) const {

return true;

}

-CPDF_FileSpec::CPDF_FileSpec() {

- m_pObj = new CPDF_Dictionary;

+CPDF_FileSpec::CPDF_FileSpec(const CFX_WeakPtr<CFX_ByteStringPool>& pPool) {

+ m_pObj = new CPDF_Dictionary(pPool);

m_pObj->AsDictionary()->SetNameFor("Type", "Filespec");

}