core/fpdfapi/fpdf_font/cpdf_font.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_font/cpdf_font.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: Address Dan's concern about outliving document Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_font/cpdf_font.cpp

diff --git a/core/fpdfapi/fpdf_font/cpdf_font.cpp b/core/fpdfapi/fpdf_font/cpdf_font.cpp

index e2eb2e567e7526b4c11091ce32ae957e307b1ef4..5d8975271416bced8614f73ab4c0653a8477b2b8 100644

--- a/core/fpdfapi/fpdf_font/cpdf_font.cpp

+++ b/core/fpdfapi/fpdf_font/cpdf_font.cpp

@@ -308,7 +308,7 @@ CPDF_Font* CPDF_Font::GetStockFont(CPDF_Document* pDoc,

if (pFont)

return pFont;

- CPDF_Dictionary* pDict = new CPDF_Dictionary;

+ CPDF_Dictionary* pDict = new CPDF_Dictionary(pDoc->GetByteStringPool());

pDict->SetNameFor("Type", "Font");

pDict->SetNameFor("Subtype", "Type1");

pDict->SetNameFor("BaseFont", fontname);