Use string pools in some dictionaries

core/fpdfapi/fpdf_parser/include/cpdf_document.h

Index: core/fpdfapi/fpdf_parser/include/cpdf_document.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_document.h b/core/fpdfapi/fpdf_parser/include/cpdf_document.h
index 0b865cb7f2a43c9e3e208d7712800b2d65bc7f8b..8fcebcc6e4af60de05d58a398dc786dd8028c588 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_document.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_document.h
@@ -13,6 +13,7 @@
 #include "core/fpdfapi/fpdf_parser/include/cpdf_indirect_object_holder.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_object.h"
 #include "core/fpdfdoc/include/cpdf_linklist.h"
+#include "core/fxcrt/include/cfx_string_pool_template.h"
 #include "core/fxcrt/include/fx_basic.h"
 
 class CFX_Font;
@@ -47,6 +48,7 @@ class CPDF_Document : public CPDF_IndirectObjectHolder {
   CPDF_Parser* GetParser() const { return m_pParser.get(); }
   CPDF_Dictionary* GetRoot() const { return m_pRootDict; }
   CPDF_Dictionary* GetInfo() const { return m_pInfoDict; }
+  CFX_ByteStringPool* GetByteStringPool() { return &m_ByteStringPool; }
 
   int GetPageCount() const;
   CPDF_Dictionary* GetPage(int iPage);
@@ -124,6 +126,7 @@ class CPDF_Document : public CPDF_IndirectObjectHolder {
   std::unique_ptr<CPDF_DocRenderData> m_pDocRender;
   std::unique_ptr<JBig2_DocumentContext> m_pCodecContext;
   std::unique_ptr<CPDF_LinkList> m_pLinksContext;
+  CFX_ByteStringPool m_ByteStringPool;

[Lei Zhang, 2016/09/20 23:48:23]

Dumb question: Why have a CFX_ByteStringPool per C[FP]DF_Document instead of
just a single global pool? Is it to release everything associated with a
document when it gets destroyed?

[Tom Sepez, 2016/09/27 20:42:56]

Exactly.  I wouldn't want an unloaded document to hold down some idiosyncratic
strings forever.

 
  private:
   void LoadDocInternal();