core/fpdfapi/fpdf_parser/cpdf_stream.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_stream.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: windows compilation Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_stream.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_stream.cpp b/core/fpdfapi/fpdf_parser/cpdf_stream.cpp

index cc584b78b3879942d579a114a927b9f2f5ba9899..645dc05eb1a366fe769d43c818544853a4118612 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_stream.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_stream.cpp

@@ -93,7 +93,7 @@ void CPDF_Stream::SetData(const uint8_t* pData, uint32_t size) {

FXSYS_memcpy(m_pDataBuf.get(), pData, size);

m_dwSize = size;

if (!m_pDict)

- m_pDict.reset(new CPDF_Dictionary);

+ m_pDict.reset(new CPDF_Dictionary(nullptr));

m_pDict->SetIntegerFor("Length", size);

m_pDict->RemoveFor("Filter");

m_pDict->RemoveFor("DecodeParms");