fpdfsdk/fpdfeditpage.cpp - Issue 2345063002: Use string pools in some dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfeditpage.cpp

Issue 2345063002: Use string pools in some dictionaries (Closed)

Patch Set: Remove default ctor Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfeditpage.cpp

diff --git a/fpdfsdk/fpdfeditpage.cpp b/fpdfsdk/fpdfeditpage.cpp

index e3777d4f8411570cf00b7367da374a5c5597f3a1..644f355c5bf8d2eb3d643dd8c75841be813530d6 100644

--- a/fpdfsdk/fpdfeditpage.cpp

+++ b/fpdfsdk/fpdfeditpage.cpp

@@ -115,10 +115,9 @@ DLLEXPORT FPDF_PAGE STDCALL FPDFPage_New(FPDF_DOCUMENT document,

pMediaBoxArray->Add(new CPDF_Number(0));

pMediaBoxArray->Add(new CPDF_Number(FX_FLOAT(width)));

pMediaBoxArray->Add(new CPDF_Number(FX_FLOAT(height)));

pPageDict->SetFor("MediaBox", pMediaBoxArray);

pPageDict->SetFor("Rotate", new CPDF_Number(0));

- pPageDict->SetFor("Resources", new CPDF_Dictionary);

+ pPageDict->SetFor("Resources", new CPDF_Dictionary(pDoc));

#ifdef PDF_ENABLE_XFA

CPDFXFA_Page* pPage =