Use string pools in some dictionaries

core/fpdfdoc/cpdf_filespec_unittest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <vector>
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_name.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_string.h"
@@ skipping 87 matching lines @@
 #else
       {L"/docs/a/test.pdf", L"/docs/a/test.pdf"},
       {L"/docs/b/test.pdf", L"/docs/b/test.pdf"},
       {L"/docs/c/test.pdf", L"/docs/c/test.pdf"},
       {L"/docs/d/test.pdf", L"/docs/d/test.pdf"},
       {L"/docs/e/test.pdf", L"/docs/e/test.pdf"},
 #endif
     };
     // Keyword fields in reverse order of precedence to retrieve the file name.
     const char* const keywords[5] = {"Unix", "Mac", "DOS", "F", "UF"};
-    ScopedDict dict_obj(new CPDF_Dictionary);
+    ScopedDict dict_obj(new CPDF_Dictionary(CFX_WeakPtr<CFX_ByteStringPool>()));
     CPDF_FileSpec file_spec(dict_obj.get());
     CFX_WideString file_name;
     for (int i = 0; i < 5; ++i) {
       dict_obj->SetFor(keywords[i], new CPDF_String(test_data[i].input));
       EXPECT_TRUE(file_spec.GetFileName(&file_name));
       EXPECT_TRUE(file_name == test_data[i].expected);
     }
 
     // With all the former fields and 'FS' field suggests 'URL' type.
     dict_obj->SetStringFor("FS", "URL");
@@ skipping 29 matching lines @@
   file_spec1.SetFileName(test_data.input);
   // Check internal object value.
   CFX_ByteString str = CFX_ByteString::FromUnicode(test_data.expected);
   EXPECT_TRUE(str == str_obj->GetString());
   // Check we can get the file name back.
   CFX_WideString file_name;
   EXPECT_TRUE(file_spec1.GetFileName(&file_name));
   EXPECT_TRUE(file_name == test_data.input);
 
   // Dictionary object.
-  ScopedDict dict_obj(new CPDF_Dictionary);
+  ScopedDict dict_obj(new CPDF_Dictionary(CFX_WeakPtr<CFX_ByteStringPool>()));
   CPDF_FileSpec file_spec2(dict_obj.get());
   file_spec2.SetFileName(test_data.input);
   // Check internal object value.
   file_name = dict_obj->GetUnicodeTextFor("F");
   EXPECT_TRUE(file_name == test_data.expected);
   file_name = dict_obj->GetUnicodeTextFor("UF");
   EXPECT_TRUE(file_name == test_data.expected);
   // Check we can get the file name back.
   EXPECT_TRUE(file_spec2.GetFileName(&file_name));
   EXPECT_TRUE(file_name == test_data.input);
 }