Use string pools in some dictionaries

core/fpdfapi/fpdf_parser/cfdf_document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/cfdf_document.h"
 
 #include "core/fpdfapi/fpdf_edit/include/cpdf_creator.h"
 #include "core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
 
 CFDF_Document::CFDF_Document()
     : CPDF_IndirectObjectHolder(),
       m_pRootDict(nullptr),
       m_pFile(nullptr),
-      m_bOwnFile(FALSE) {}
+      m_bOwnFile(FALSE),
+      m_pByteStringPool(WrapUnique(new CFX_ByteStringPool)) {}
 
 CFDF_Document::~CFDF_Document() {
   if (m_bOwnFile && m_pFile)
     m_pFile->Release();
+  m_pByteStringPool.Clear();  // Make weak.
 }
 
 CFDF_Document* CFDF_Document::CreateNewDoc() {
   CFDF_Document* pDoc = new CFDF_Document;
-  pDoc->m_pRootDict = new CPDF_Dictionary;
+  pDoc->m_pRootDict = new CPDF_Dictionary(pDoc->GetByteStringPool());
   pDoc->AddIndirectObject(pDoc->m_pRootDict);
-  pDoc->m_pRootDict->SetFor("FDF", new CPDF_Dictionary);
+  pDoc->m_pRootDict->SetFor("FDF",
+                            new CPDF_Dictionary(pDoc->GetByteStringPool()));
   return pDoc;
 }
 
 CFDF_Document* CFDF_Document::ParseFile(IFX_FileRead* pFile, FX_BOOL bOwnFile) {
   if (!pFile)
     return nullptr;
 
   std::unique_ptr<CFDF_Document> pDoc(new CFDF_Document);
   pDoc->ParseStream(pFile, bOwnFile);
   return pDoc->m_pRootDict ? pDoc.release() : nullptr;
@@ skipping 50 matching lines @@
 
   buf << "%FDF-1.2\r\n";
   for (const auto& pair : *this)
     buf << pair.first << " 0 obj\r\n"
         << pair.second.get() << "\r\nendobj\r\n\r\n";
 
   buf << "trailer\r\n<</Root " << m_pRootDict->GetObjNum()
       << " 0 R>>\r\n%%EOF\r\n";
   return TRUE;
 }