Use string pools in some dictionaries

core/fpdfapi/fpdf_page/cpdf_image.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/include/cpdf_image.h"
 
 #include <algorithm>
 #include <memory>
@@ skipping 67 matching lines @@
   int32_t width;
   int32_t height;
   int32_t num_comps;
   int32_t bits;
   bool color_trans;
   if (!CPDF_ModuleMgr::Get()->GetJpegModule()->LoadInfo(
           pData, size, &width, &height, &num_comps, &bits, &color_trans)) {
     return nullptr;
   }
 
-  CPDF_Dictionary* pDict = new CPDF_Dictionary;
+  CPDF_Dictionary* pDict =
+      new CPDF_Dictionary(m_pDocument->GetByteStringPool());
   pDict->SetNameFor("Type", "XObject");
   pDict->SetNameFor("Subtype", "Image");
   pDict->SetIntegerFor("Width", width);
   pDict->SetIntegerFor("Height", height);
   const FX_CHAR* csname = nullptr;
   if (num_comps == 1) {
     csname = "DeviceGray";
   } else if (num_comps == 3) {
     csname = "DeviceRGB";
   } else if (num_comps == 4) {
     csname = "DeviceCMYK";
     CPDF_Array* pDecode = new CPDF_Array;
     for (int n = 0; n < 4; n++) {
       pDecode->AddInteger(1);
       pDecode->AddInteger(0);
     }
     pDict->SetFor("Decode", pDecode);
   }
   pDict->SetNameFor("ColorSpace", csname);
   pDict->SetIntegerFor("BitsPerComponent", bits);
   pDict->SetNameFor("Filter", "DCTDecode");
   if (!color_trans) {
-    CPDF_Dictionary* pParms = new CPDF_Dictionary;
+    CPDF_Dictionary* pParms =
+        new CPDF_Dictionary(m_pDocument->GetByteStringPool());
     pDict->SetFor("DecodeParms", pParms);
     pParms->SetIntegerFor("ColorTransform", 0);
   }
   m_bIsMask = FALSE;
   m_Width = width;
   m_Height = height;
   if (!m_pStream)
     m_pStream = new CPDF_Stream;
   return pDict;
 }
@@ skipping 21 matching lines @@
 void CPDF_Image::SetImage(const CFX_DIBitmap* pBitmap, int32_t iCompress) {
   int32_t BitmapWidth = pBitmap->GetWidth();
   int32_t BitmapHeight = pBitmap->GetHeight();
   if (BitmapWidth < 1 || BitmapHeight < 1) {
     return;
   }
   uint8_t* src_buf = pBitmap->GetBuffer();
   int32_t src_pitch = pBitmap->GetPitch();
   int32_t bpp = pBitmap->GetBPP();
 
-  CPDF_Dictionary* pDict = new CPDF_Dictionary;
+  CPDF_Dictionary* pDict =
+      new CPDF_Dictionary(m_pDocument->GetByteStringPool());
   pDict->SetNameFor("Type", "XObject");
   pDict->SetNameFor("Subtype", "Image");
   pDict->SetIntegerFor("Width", BitmapWidth);
   pDict->SetIntegerFor("Height", BitmapHeight);
   uint8_t* dest_buf = nullptr;
   FX_STRSIZE dest_pitch = 0, dest_size = 0, opType = -1;
   if (bpp == 1) {
     int32_t reset_a = 0, reset_r = 0, reset_g = 0, reset_b = 0;
     int32_t set_a = 0, set_r = 0, set_g = 0, set_b = 0;
     if (!pBitmap->IsAlphaMask()) {
@@ skipping 42 matching lines @@
       pCS->AddInteger(iPalette - 1);
       uint8_t* pColorTable = FX_Alloc2D(uint8_t, iPalette, 3);
       uint8_t* ptr = pColorTable;
       for (int32_t i = 0; i < iPalette; i++) {
         uint32_t argb = pBitmap->GetPaletteArgb(i);
         ptr[0] = (uint8_t)(argb >> 16);
         ptr[1] = (uint8_t)(argb >> 8);
         ptr[2] = (uint8_t)argb;
         ptr += 3;
       }
-      CPDF_Stream* pCTS =
-          new CPDF_Stream(pColorTable, iPalette * 3, new CPDF_Dictionary);
+      CPDF_Stream* pCTS = new CPDF_Stream(
+          pColorTable, iPalette * 3,
+          new CPDF_Dictionary(m_pDocument->GetByteStringPool()));
       pCS->AddReference(m_pDocument, m_pDocument->AddIndirectObject(pCTS));
       pDict->SetReferenceFor("ColorSpace", m_pDocument,
                              m_pDocument->AddIndirectObject(pCS));
     } else {
       pDict->SetNameFor("ColorSpace", "DeviceGray");
     }
     pDict->SetIntegerFor("BitsPerComponent", 8);
     if ((iCompress & 0x03) == PDF_IMAGE_NO_COMPRESS) {
       dest_pitch = BitmapWidth;
       opType = 1;
@@ skipping 14 matching lines @@
   FX_BOOL bDeleteMask = FALSE;
   if (pBitmap->HasAlpha()) {
     pMaskBitmap = pBitmap->GetAlphaMask();
     bDeleteMask = TRUE;
   }
   if (pMaskBitmap) {
     int32_t maskWidth = pMaskBitmap->GetWidth();
     int32_t maskHeight = pMaskBitmap->GetHeight();
     uint8_t* mask_buf = nullptr;
     FX_STRSIZE mask_size = 0;
-    CPDF_Dictionary* pMaskDict = new CPDF_Dictionary;
+    CPDF_Dictionary* pMaskDict =
+        new CPDF_Dictionary(m_pDocument->GetByteStringPool());
     pMaskDict->SetNameFor("Type", "XObject");
     pMaskDict->SetNameFor("Subtype", "Image");
     pMaskDict->SetIntegerFor("Width", maskWidth);
     pMaskDict->SetIntegerFor("Height", maskHeight);
     pMaskDict->SetNameFor("ColorSpace", "DeviceGray");
     pMaskDict->SetIntegerFor("BitsPerComponent", 8);
     if (pMaskBitmap->GetBPP() == 8 &&
         (iCompress & PDF_IMAGE_MASK_LOSSY_COMPRESS) != 0) {
     } else if (pMaskBitmap->GetFormat() == FXDIB_1bppMask) {
     } else {
@@ skipping 134 matching lines @@
   }
   if (!ret) {
     delete m_pDIBSource;
     m_pDIBSource = nullptr;
     return FALSE;
   }
   m_pMask = pSource->DetachMask();
   m_MatteColor = pSource->GetMatteColor();
   return FALSE;
 }