Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)
Patch Set: Addressed review comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/public/browser/navigation_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 1c65544982e749b10cb22f40a019ac4e800e5ef4..eae9cd46bb8b6910c79c93eb67b4ac1215d7c657 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -70,12 +70,6 @@ class CONTENT_EXPORT NavigationHandle {
// * using window.history.pushState
virtual bool IsRendererInitiated() = 0;
- // Whether the navigation is synchronous or not. Examples of synchronous
- // navigations are:
- // * reference fragment navigations
- // * pushState/popState
- virtual bool IsSynchronousNavigation() = 0;
-
// Whether the navigation is for an iframe with srcdoc attribute.
virtual bool IsSrcdoc() = 0;
@@ -146,9 +140,10 @@ class CONTENT_EXPORT NavigationHandle {
// called.
virtual RenderFrameHost* GetRenderFrameHost() = 0;
- // Whether the navigation happened in the same page. This is only known
- // after the navigation has committed. It is an error to call this method
- // before the navigation has committed.
+ // Whether the navigation happened in the same page. Examples of same page
+ // navigations are:
+ // * reference fragment navigations
+ // * pushState/replaceState
virtual bool IsSamePage() = 0;
// Whether the navigation has encountered a server redirect or not.
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/public/browser/navigation_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698