content/browser/frame_host/navigator_impl.cc - Issue 2345053006: Remove IsSynchronous API from NavigationHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)

Patch Set: Addressed review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index b2838218b226b055177d6dd37aed44d9a2ef6a32..03770eb4a458ccaba769840e0b2bfd975e223888 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -207,7 +207,7 @@ void NavigatorImpl::DidStartProvisionalLoad(

render_frame_host->SetNavigationHandle(NavigationHandleImpl::Create(

validated_url, render_frame_host->frame_tree_node(),

is_renderer_initiated,

- false, // is_synchronous

+ false, // is_same_page

is_iframe_srcdoc, // is_srcdoc

navigation_start, pending_nav_entry_id, started_from_context_menu));

}