chrome/browser/extensions/api/web_navigation/web_navigation_api.cc - Issue 2345053006: Remove IsSynchronous API from NavigationHandle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 2345053006: Remove IsSynchronous API from NavigationHandle. (Closed)

Patch Set: Addressed review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

index c483f855d61a0df4e122227e686c39541f63dd96..f525af6bb57b0c714772b23faede33cc64b4fad4 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

@@ -268,7 +268,7 @@ void WebNavigationTabObserver::RenderFrameHostChanged(

void WebNavigationTabObserver::DidStartNavigation(

content::NavigationHandle* navigation_handle) {

- if (navigation_handle->IsSynchronousNavigation() ||

+ if (navigation_handle->IsSamePage() ||

!FrameNavigationState::IsValidUrl(navigation_handle->GetURL())) {

return;

}